Browse Source

ref(crons): Remove owner_actor_id (state) (#68833)

Waiting on GH-68825
Evan Purkhiser 11 months ago
parent
commit
c12ae52022

+ 1 - 1
migrations_lockfile.txt

@@ -9,5 +9,5 @@ feedback: 0004_index_together
 hybridcloud: 0016_add_control_cacheversion
 nodestore: 0002_nodestore_no_dictfield
 replays: 0004_index_together
-sentry: 0695_add_monitors_ownership_owner_user_id_team_id
+sentry: 0696_remove_monitor_owner_actor_id
 social_auth: 0002_default_auto_field

+ 34 - 0
src/sentry/migrations/0696_remove_monitor_owner_actor_id.py

@@ -0,0 +1,34 @@
+# Generated by Django 5.0.3 on 2024-04-12 19:49
+
+from django.db import migrations
+
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = False
+
+    dependencies = [
+        ("sentry", "0695_add_monitors_ownership_owner_user_id_team_id"),
+    ]
+
+    operations = [
+        migrations.SeparateDatabaseAndState(
+            database_operations=[],
+            state_operations=[
+                migrations.RemoveField(model_name="monitor", name="owner_actor_id"),
+            ],
+        )
+    ]

+ 0 - 7
src/sentry/monitors/models.py

@@ -251,13 +251,6 @@ class Monitor(Model):
     Type of monitor. Currently there are only CRON_JOB monitors.
     """
 
-    owner_actor_id = BoundedBigIntegerField(null=True, db_index=True)
-    """
-    The owner of the monitors actor_id.
-
-    @deprecated Will be replaced with user_id / team_id
-    """
-
     owner_user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="CASCADE")
     """
     The user assigned as the owner of this model.

File diff suppressed because it is too large
+ 204 - 205
tests/sentry/backup/snapshots/ReleaseTests/test_at_head.pysnap


Some files were not shown because too many files changed in this diff