chore(insights): Remove "Resources" --> "Assets" conditionals (#72720)

The module is called "Assets" everywhere now, no need for conditionals.
The only thing left is a redirect from `/browser/resources/` to
`/browser/assets/`.

static/app/components/events/interfaces/spans/spanSummaryButton.tsx

@@ -4,10 +4,7 @@ import {t, tct} from 'sentry/locale';
 import type {EventTransaction, Organization} from 'sentry/types';
 import {trackAnalytics} from 'sentry/utils/analytics';
 import {useLocation} from 'sentry/utils/useLocation';
-import {
-  DATA_TYPE as RESOURCE_DATA_TYPE,
-  PERFORMANCE_DATA_TYPE as PERFORMANCE_RESOURCE_DATA_TYPE,
-} from 'sentry/views/performance/browser/resources/settings';
+import {DATA_TYPE} from 'sentry/views/performance/browser/resources/settings';
 import {
   querySummaryRouteWithQuery,
   resourceSummaryRouteWithQuery,
@@ -34,11 +31,6 @@ function SpanSummaryButton(props: Props) {
   }
 
   const resolvedModule = resolveSpanModule(sentryTags.op, sentryTags.category);
-  const isInsightsEnabled = organization.features.includes('performance-insights');
-
-  const resourceDataType = isInsightsEnabled
-    ? RESOURCE_DATA_TYPE
-    : PERFORMANCE_RESOURCE_DATA_TYPE;
 
   if (
     organization.features.includes('insights-initial-modules') &&
@@ -86,7 +78,7 @@ function SpanSummaryButton(props: Props) {
           });
         }}
       >
-        {tct('View [dataType] Summary', {dataType: resourceDataType})}
+        {tct('View [dataType] Summary', {dataType: DATA_TYPE})}
       </LinkButton>
     );
   }

static/app/components/sidebar/index.spec.tsx

@@ -366,7 +366,7 @@ describe('Sidebar', function () {
         /Queues/,
         'Screen Loads',
         'App Starts',
-        'Resources',
+        'Assets',
         /Mobile UI/,
         /Traces/,
         'Profiling',

static/app/routes.tsx

@@ -19,7 +19,6 @@ import IssueListOverview from 'sentry/views/issueList/overview';
 import OrganizationContainer from 'sentry/views/organizationContainer';
 import OrganizationLayout from 'sentry/views/organizationLayout';
 import OrganizationRoot from 'sentry/views/organizationRoot';
-import {PERFORMANCE_BASE_URL as PERFORMANCE_RESOURCE_BASE_URL} from 'sentry/views/performance/browser/resources/settings';
 import {MODULE_BASE_URLS} from 'sentry/views/performance/utils/useModuleURL';
 import ProjectEventRedirect from 'sentry/views/projectEventRedirect';
 import redirectDeprecatedProjectRoute from 'sentry/views/projects/redirectDeprecatedProjectRoute';
@@ -1497,6 +1496,10 @@ function buildRoutes() {
           )}
         />
       </Route>
+      <Redirect
+        from="browser/resources/"
+        to={`${MODULE_BASE_URLS[ModuleName.RESOURCE]}/`}
+      />
       <Route path={`${MODULE_BASE_URLS[ModuleName.RESOURCE]}/`}>
         <IndexRoute
           component={make(
@@ -1513,22 +1516,6 @@ function buildRoutes() {
           )}
         />
       </Route>
-      <Route path={`${PERFORMANCE_RESOURCE_BASE_URL}/`}>
-        <IndexRoute
-          component={make(
-            () => import('sentry/views/performance/browser/resources/index')
-          )}
-        />
-        <Route
-          path="spans/span/:groupId/"
-          component={make(
-            () =>
-              import(
-                'sentry/views/performance/browser/resources/resourceSummaryPage/index'
-              )
-          )}
-        />
-      </Route>
       <Route path={`${MODULE_BASE_URLS[ModuleName.QUEUE]}/`}>
         <IndexRoute
           component={make(

static/app/views/performance/browser/resources/index.tsx

@@ -13,7 +13,6 @@ import {PageHeadingQuestionTooltip} from 'sentry/components/pageHeadingQuestionT
 import {space} from 'sentry/styles/space';
 import {RateUnit} from 'sentry/utils/discover/fields';
 import {PageAlert, PageAlertProvider} from 'sentry/utils/performance/contexts/pageAlert';
-import useOrganization from 'sentry/utils/useOrganization';
 import ResourceView, {
   DEFAULT_RESOURCE_TYPES,
   FilterOptionsContainer,
@@ -21,7 +20,6 @@ import ResourceView, {
 import {
   MODULE_DESCRIPTION,
   MODULE_DOC_LINK,
-  PERFORMANCE_MODULE_DESCRIPTION,
 } from 'sentry/views/performance/browser/resources/settings';
 import {
   BrowserStarfishFields,
@@ -40,11 +38,9 @@ export const RESOURCE_THROUGHPUT_UNIT = RateUnit.PER_MINUTE;
 
 function ResourcesLandingPage() {
   const filters = useResourceModuleFilters();
-  const organization = useOrganization();
   const moduleTitle = useModuleTitle(ModuleName.RESOURCE);
 
   const crumbs = useModuleBreadcrumbs('resource');
-  const isInsightsEnabled = organization.features.includes('performance-insights');
 
   return (
     <React.Fragment>
@@ -57,9 +53,7 @@ function ResourcesLandingPage() {
               {moduleTitle}
               <PageHeadingQuestionTooltip
                 docsUrl={MODULE_DOC_LINK}
-                title={
-                  isInsightsEnabled ? MODULE_DESCRIPTION : PERFORMANCE_MODULE_DESCRIPTION
-                }
+                title={MODULE_DESCRIPTION}
               />
             </Layout.Title>
           </Layout.HeaderContent>

static/app/views/performance/browser/resources/resourceSummaryPage/index.tsx

@@ -12,7 +12,6 @@ import {ProjectPageFilter} from 'sentry/components/organizations/projectPageFilt
 import {t, tct} from 'sentry/locale';
 import {MutableSearch} from 'sentry/utils/tokenizeSearch';
 import {useLocation} from 'sentry/utils/useLocation';
-import useOrganization from 'sentry/utils/useOrganization';
 import {useParams} from 'sentry/utils/useParams';
 import {Referrer} from 'sentry/views/performance/browser/resources/referrer';
 import ResourceInfo from 'sentry/views/performance/browser/resources/resourceSummaryPage/resourceInfo';
@@ -20,10 +19,7 @@ import ResourceSummaryCharts from 'sentry/views/performance/browser/resources/re
 import ResourceSummaryTable from 'sentry/views/performance/browser/resources/resourceSummaryPage/resourceSummaryTable';
 import SampleImages from 'sentry/views/performance/browser/resources/resourceSummaryPage/sampleImages';
 import {FilterOptionsContainer} from 'sentry/views/performance/browser/resources/resourceView';
-import {
-  DATA_TYPE,
-  PERFORMANCE_DATA_TYPE,
-} from 'sentry/views/performance/browser/resources/settings';
+import {DATA_TYPE} from 'sentry/views/performance/browser/resources/settings';
 import {IMAGE_FILE_EXTENSIONS} from 'sentry/views/performance/browser/resources/shared/constants';
 import RenderBlockingSelector from 'sentry/views/performance/browser/resources/shared/renderBlockingSelector';
 import {ResourceSpanOps} from 'sentry/views/performance/browser/resources/shared/types';
@@ -48,7 +44,6 @@ const {
 
 function ResourceSummary() {
   const webVitalsModuleURL = useModuleURL('vital');
-  const organization = useOrganization();
   const {groupId} = useParams();
   const filters = useResourceModuleFilters();
   const selectedSpanOp = filters[SPAN_OP];
@@ -90,9 +85,6 @@ function ResourceSummary() {
 
   const crumbs = useModuleBreadcrumbs('resource');
 
-  const isInsightsEnabled = organization.features.includes('performance-insights');
-  const resourceDataType = isInsightsEnabled ? DATA_TYPE : PERFORMANCE_DATA_TYPE;
-
   return (
     <React.Fragment>
       <Layout.Header>
@@ -101,7 +93,7 @@ function ResourceSummary() {
             crumbs={[
               ...crumbs,
               {
-                label: tct('[dataType] Summary', {dataType: resourceDataType}),
+                label: tct('[dataType] Summary', {dataType: DATA_TYPE}),
               },
             ]}
           />
@@ -159,14 +151,10 @@ function ResourceSummary() {
 }
 
 function PageWithProviders() {
-  const organization = useOrganization();
-
-  const isInsightsEnabled = organization.features.includes('performance-insights');
-  const resourceDataType = isInsightsEnabled ? DATA_TYPE : PERFORMANCE_DATA_TYPE;
   return (
     <ModulePageProviders
       moduleName="resource"
-      pageTitle={`${resourceDataType} ${t('Summary')}`}
+      pageTitle={`${DATA_TYPE} ${t('Summary')}`}
       features="insights-initial-modules"
     >
       <ResourceSummary />

static/app/views/performance/browser/resources/resourceSummaryPage/resourceSummaryCharts.tsx

@@ -3,13 +3,9 @@ import {formatBytesBase2} from 'sentry/utils/bytes/formatBytesBase2';
 import {formatRate} from 'sentry/utils/formatters';
 import getDynamicText from 'sentry/utils/getDynamicText';
 import {MutableSearch} from 'sentry/utils/tokenizeSearch';
-import useOrganization from 'sentry/utils/useOrganization';
 import {RESOURCE_THROUGHPUT_UNIT} from 'sentry/views/performance/browser/resources';
 import {Referrer} from 'sentry/views/performance/browser/resources/referrer';
-import {
-  DATA_TYPE,
-  PERFORMANCE_DATA_TYPE,
-} from 'sentry/views/performance/browser/resources/settings';
+import {DATA_TYPE} from 'sentry/views/performance/browser/resources/settings';
 import {useResourceModuleFilters} from 'sentry/views/performance/browser/resources/utils/useResourceFilters';
 import {AVG_COLOR, THROUGHPUT_COLOR} from 'sentry/views/starfish/colors';
 import Chart, {ChartType} from 'sentry/views/starfish/components/chart';
@@ -33,10 +29,6 @@ const {
 
 function ResourceSummaryCharts(props: {groupId: string}) {
   const filters = useResourceModuleFilters();
-  const organization = useOrganization();
-
-  const isInsightsEnabled = organization.features.includes('performance-insights');
-  const resourceDataType = isInsightsEnabled ? DATA_TYPE : PERFORMANCE_DATA_TYPE;
 
   const {data: spanMetricsSeriesData, isLoading: areSpanMetricsSeriesLoading} =
     useSpanMetricsSeries(
@@ -105,7 +97,7 @@ function ResourceSummaryCharts(props: {groupId: string}) {
         </ChartPanel>
       </Block>
       <Block>
-        <ChartPanel title={tct('Average [dataType] Size', {dataType: resourceDataType})}>
+        <ChartPanel title={tct('Average [dataType] Size', {dataType: DATA_TYPE})}>
           <Chart
             height={160}
             aggregateOutputFormat="size"

static/app/views/performance/browser/resources/resourceView/resourceTable.tsx

@@ -16,10 +16,7 @@ import {decodeScalar} from 'sentry/utils/queryString';
 import {useLocation} from 'sentry/utils/useLocation';
 import useOrganization from 'sentry/utils/useOrganization';
 import {RESOURCE_THROUGHPUT_UNIT} from 'sentry/views/performance/browser/resources';
-import {
-  DATA_TYPE,
-  PERFORMANCE_DATA_TYPE,
-} from 'sentry/views/performance/browser/resources/settings';
+import {DATA_TYPE} from 'sentry/views/performance/browser/resources/settings';
 import {
   FONT_FILE_EXTENSIONS,
   IMAGE_FILE_EXTENSIONS,
@@ -79,9 +76,6 @@ function ResourceTable({sort, defaultResourceTypes}: Props) {
   const cursor = decodeScalar(location.query?.[QueryParameterNames.SPANS_CURSOR]);
   const {setPageInfo, pageAlert} = usePageAlert();
 
-  const isInsightsEnabled = organization.features.includes('performance-insights');
-  const resourceDataType = isInsightsEnabled ? DATA_TYPE : PERFORMANCE_DATA_TYPE;
-
   const {data, isLoading, pageLinks} = useResourcesQuery({
     sort,
     defaultResourceTypes,
@@ -93,7 +87,7 @@ function ResourceTable({sort, defaultResourceTypes}: Props) {
     {
       key: SPAN_DESCRIPTION,
       width: COL_WIDTH_UNDEFINED,
-      name: `${resourceDataType} ${t('Description')}`,
+      name: `${DATA_TYPE} ${t('Description')}`,
     },
     {
       key: `${SPM}()`,

static/app/views/performance/browser/resources/settings.ts

@@ -7,11 +7,4 @@ export const MODULE_DESCRIPTION = t(
   'Find large and slow-to-load resources used by your application and understand their impact on page performance.'
 );
 
-export const PERFORMANCE_MODULE_TITLE = t('Resources');
-export const PERFORMANCE_BASE_URL = 'browser/resources';
-export const PERFORMANCE_DATA_TYPE = t('Resource');
-export const PERFORMANCE_MODULE_DESCRIPTION = t(
-  'Find large and slow-to-load resources used by your application and understand their impact on page performance.'
-);
-
 export const MODULE_DOC_LINK = 'https://docs.sentry.io/product/insights/assets/';

static/app/views/performance/utils/useModuleTitle.tsx

@@ -1,9 +1,5 @@
-import useOrganization from 'sentry/utils/useOrganization';
 import {MODULE_TITLE as AI_MODULE_TITLE} from 'sentry/views/llmMonitoring/settings';
-import {
-  MODULE_TITLE as RESOURCES_MODULE_TITLE,
-  PERFORMANCE_MODULE_TITLE as PERFORMANCE_RESOURCES_MODULE_TITLE,
-} from 'sentry/views/performance/browser/resources/settings';
+import {MODULE_TITLE as RESOURCES_MODULE_TITLE} from 'sentry/views/performance/browser/resources/settings';
 import {MODULE_TITLE as VITALS_MODULE_TITLE} from 'sentry/views/performance/browser/webVitals/settings';
 import {MODULE_TITLE as CACHE_MODULE_TITLE} from 'sentry/views/performance/cache/settings';
 import {MODULE_TITLE as DB_MODULE_TITLE} from 'sentry/views/performance/database/settings';
@@ -33,12 +29,5 @@ type ModuleNameStrings = `${ModuleName}`;
 type TitleableModuleNames = Exclude<ModuleNameStrings, '' | 'other'>;
 
 export function useModuleTitle(moduleName: TitleableModuleNames) {
-  const organization = useOrganization({allowNull: true});
-  const isInsightsEnabled = organization?.features?.includes('performance-insights');
-
-  if (!isInsightsEnabled && moduleName === ModuleName.RESOURCE) {
-    return PERFORMANCE_RESOURCES_MODULE_TITLE;
-  }
-
   return MODULE_TITLES[moduleName];
 }

static/app/views/performance/utils/useModuleURL.tsx

@@ -1,10 +1,7 @@
 import useOrganization from 'sentry/utils/useOrganization';
 import {normalizeUrl} from 'sentry/utils/withDomainRequired';
 import {BASE_URL as AI_BASE_URL} from 'sentry/views/llmMonitoring/settings';
-import {
-  BASE_URL as RESOURCES_BASE_URL,
-  PERFORMANCE_BASE_URL as PERFORMANCE_RESOURCES_BASE_URL,
-} from 'sentry/views/performance/browser/resources/settings';
+import {BASE_URL as RESOURCES_BASE_URL} from 'sentry/views/performance/browser/resources/settings';
 import {BASE_URL as VITALS_BASE_URL} from 'sentry/views/performance/browser/webVitals/settings';
 import {BASE_URL as CACHE_BASE_URL} from 'sentry/views/performance/cache/settings';
 import {BASE_URL as DB_BASE_URL} from 'sentry/views/performance/database/settings';
@@ -46,7 +43,6 @@ type URLBuilder = (moduleName: RoutableModuleNames) => string;
 
 export function useModuleURLBuilder(bare: boolean = false): URLBuilder {
   const organization = useOrganization({allowNull: true}); // Some parts of the app, like the main sidebar, render even if the organization isn't available (during loading, or at all).
-  const isInsightsEnabled = organization?.features?.includes('performance-insights');
 
   const insightsURLBuilder = useInsightsURLBuilder();
 
@@ -69,14 +65,6 @@ export function useModuleURLBuilder(bare: boolean = false): URLBuilder {
         : normalizeUrl(`/organizations/${slug}/${moduleURLSegment}`);
     }
 
-    if (!isInsightsEnabled && moduleName === ModuleName.RESOURCE) {
-      return bare
-        ? `${insightsURL}/${PERFORMANCE_RESOURCES_BASE_URL}`
-        : normalizeUrl(
-            `/organizations/${slug}/${insightsURL}/${PERFORMANCE_RESOURCES_BASE_URL}`
-          );
-    }
-
     return bare
       ? `${insightsURL}/${MODULE_BASE_URLS[moduleName]}`
       : normalizeUrl(