feat(apis): Correcting some ownerships (#63388)

More API ownership assignment and corrections. I'll add inline comments.

api-docs/openapi.json

@@ -108,9 +108,6 @@
     "/api/0/organizations/{organization_slug}/repos/{repo_id}/commits/": {
       "$ref": "paths/organizations/repo-commits.json"
     },
-    "/api/0/organizations/{organization_slug}/stats/": {
-      "$ref": "paths/organizations/stats.json"
-    },
     "/api/0/organizations/{organization_slug}/sessions/": {
       "$ref": "paths/releases/sessions.json"
     },

api-docs/paths/organizations/stats.json

@@ -1,113 +0,0 @@
-{
-  "get": {
-    "tags": ["Organizations"],
-    "deprecated": true,
-    "description": "This endpoint is deprecated in favor of [Organization Stats V2](/api/organizations/retrieve-event-counts-for-an-organization-v2/).",
-    "operationId": "Retrieve Event Counts for an Organization",
-    "parameters": [
-      {
-        "name": "organization_slug",
-        "in": "path",
-        "description": "The slug of the organization the event ID should be looked up in.",
-        "required": true,
-        "schema": {
-          "type": "string"
-        }
-      },
-      {
-        "name": "stat",
-        "in": "query",
-        "description": "The name of the stat to query `(\"received\", \"rejected\", \"blacklisted\")`.",
-        "schema": {
-          "type": "string",
-          "enum": ["received", "rejected", "blacklisted"]
-        }
-      },
-      {
-        "name": "since",
-        "in": "query",
-        "description": "A timestamp to set the start of the query in seconds since UNIX epoch.",
-        "schema": {
-          "type": "string",
-          "format": "date-time"
-        }
-      },
-      {
-        "name": "until",
-        "in": "query",
-        "description": "A timestamp to set the end of the query in seconds since UNIX epoch.",
-        "schema": {
-          "type": "string",
-          "format": "date-time"
-        }
-      },
-      {
-        "name": "resolution",
-        "in": "query",
-        "description": "An explicit resolution to search for (one of `10s`, `1h`, and `1d`).",
-        "schema": {
-          "type": "string",
-          "enum": ["10s", "1h", "1d"]
-        }
-      }
-    ],
-    "responses": {
-      "200": {
-        "description": "Success",
-        "content": {
-          "application/json": {
-            "schema": {
-              "type": "array",
-              "items": {
-                "type": "array",
-                "items": {
-                  "type": "integer"
-                }
-              }
-            },
-            "example": [
-              [1541455200.0, 8264],
-              [1541458800.0, 6564],
-              [1541462400.0, 8652],
-              [1541466000.0, 7436],
-              [1541469600.0, 8127],
-              [1541473200.0, 7643],
-              [1541476800.0, 6518],
-              [1541480400.0, 6752],
-              [1541484000.0, 6559],
-              [1541487600.0, 7039],
-              [1541491200.0, 7384],
-              [1541494800.0, 6265],
-              [1541498400.0, 8390],
-              [1541502000.0, 6393],
-              [1541505600.0, 7298],
-              [1541509200.0, 7422],
-              [1541512800.0, 5603],
-              [1541516400.0, 6846],
-              [1541520000.0, 8886],
-              [1541523600.0, 6544],
-              [1541527200.0, 8812],
-              [1541530800.0, 8172],
-              [1541534400.0, 5733],
-              [1541538000.0, 9435]
-            ]
-          }
-        }
-      },
-      "403": {
-        "description": "Forbidden"
-      },
-      "401": {
-        "description": "Unauthorized"
-      },
-      "404": {
-        "description": "Not Found"
-      }
-    },
-    "security": [
-      {
-        "auth_token": ["org: read"]
-      }
-    ]
-  }
-}

src/sentry/api/api_owners.py

@@ -9,7 +9,6 @@ class ApiOwner(Enum):
 
     BILLING = "revenue"
     CRONS = "crons"
-    DATA = "data"
     DISCOVER_N_DASHBOARDS = "discover-n-dashboards"
     ECOSYSTEM = "ecosystem"
     ENTERPRISE = "enterprise"

src/sentry/api/endpoints/organization_api_key_details.py

@@ -25,9 +25,9 @@ class ApiKeySerializer(serializers.ModelSerializer):
 class OrganizationApiKeyDetailsEndpoint(ControlSiloOrganizationEndpoint):
     owner = ApiOwner.ECOSYSTEM
     publish_status = {
-        "DELETE": ApiPublishStatus.UNKNOWN,
-        "GET": ApiPublishStatus.UNKNOWN,
-        "PUT": ApiPublishStatus.UNKNOWN,
+        "DELETE": ApiPublishStatus.PRIVATE,
+        "GET": ApiPublishStatus.PRIVATE,
+        "PUT": ApiPublishStatus.PRIVATE,
     }
     permission_classes = (OrganizationAdminPermission,)
 

src/sentry/api/endpoints/organization_api_key_index.py

@@ -20,8 +20,8 @@ DEFAULT_SCOPES = ["project:read", "event:read", "team:read", "org:read", "member
 class OrganizationApiKeyIndexEndpoint(ControlSiloOrganizationEndpoint):
     owner = ApiOwner.ECOSYSTEM
     publish_status = {
-        "GET": ApiPublishStatus.UNKNOWN,
-        "POST": ApiPublishStatus.UNKNOWN,
+        "GET": ApiPublishStatus.PRIVATE,
+        "POST": ApiPublishStatus.PRIVATE,
     }
     permission_classes = (OrganizationAdminPermission,)
 

src/sentry/api/endpoints/organization_member_unreleased_commits.py

@@ -44,7 +44,7 @@ from rest_framework.response import Response
 
 @region_silo_endpoint
 class OrganizationMemberUnreleasedCommitsEndpoint(OrganizationMemberEndpoint):
-    owner = ApiOwner.ECOSYSTEM
+    owner = ApiOwner.UNOWNED
     publish_status = {
         "GET": ApiPublishStatus.UNKNOWN,
     }

src/sentry/api/endpoints/organization_pinned_searches.py

@@ -30,7 +30,7 @@ class OrganizationSearchSerializer(serializers.Serializer):
 
 @region_silo_endpoint
 class OrganizationPinnedSearchEndpoint(OrganizationEndpoint):
-    owner = ApiOwner.OWNERS_SNUBA
+    owner = ApiOwner.UNOWNED
     publish_status = {
         "DELETE": ApiPublishStatus.UNKNOWN,
         "PUT": ApiPublishStatus.UNKNOWN,

src/sentry/api/endpoints/organization_recent_searches.py

@@ -26,7 +26,7 @@ class OrganizationRecentSearchPermission(OrganizationPermission):
 
 @region_silo_endpoint
 class OrganizationRecentSearchesEndpoint(OrganizationEndpoint):
-    owner = ApiOwner.OWNERS_SNUBA
+    owner = ApiOwner.UNOWNED
     publish_status = {
         "GET": ApiPublishStatus.UNKNOWN,
         "POST": ApiPublishStatus.UNKNOWN,

src/sentry/api/endpoints/organization_search_details.py

@@ -36,7 +36,7 @@ class OrganizationSearchEditPermission(OrganizationSearchPermission):
 
 @region_silo_endpoint
 class OrganizationSearchDetailsEndpoint(OrganizationEndpoint):
-    owner = ApiOwner.OWNERS_SNUBA
+    owner = ApiOwner.UNOWNED
     publish_status = {
         "DELETE": ApiPublishStatus.UNKNOWN,
         "PUT": ApiPublishStatus.UNKNOWN,

src/sentry/api/endpoints/organization_stats.py

@@ -16,7 +16,8 @@ from sentry.tsdb.base import TSDBModel
 @region_silo_endpoint
 class OrganizationStatsEndpoint(OrganizationEndpoint, EnvironmentMixin, StatsMixin):
     publish_status = {
-        "GET": ApiPublishStatus.UNKNOWN,
+        # Deprecated APIs remain private until removed
+        "GET": ApiPublishStatus.PRIVATE,
     }
     owner = ApiOwner.ENTERPRISE