Browse Source

ref(ui): Rename and type componentDidUpdate arguments (#29533)

Matej Minar 3 years ago
parent
commit
bd30b2214e

+ 2 - 2
static/app/views/releases/detail/commitsAndFiles/commits.tsx

@@ -52,12 +52,12 @@ class Commits extends AsyncView<Props, State> {
     };
   }
 
-  componentDidUpdate(prevProps: Props, prevContext: Record<string, any>) {
+  componentDidUpdate(prevProps: Props, prevState: State) {
     if (prevProps.activeReleaseRepo?.name !== this.props.activeReleaseRepo?.name) {
       this.remountComponent();
       return;
     }
-    super.componentDidUpdate(prevProps, prevContext);
+    super.componentDidUpdate(prevProps, prevState);
   }
 
   getEndpoints(): ReturnType<AsyncView['getEndpoints']> {

+ 2 - 2
static/app/views/releases/detail/commitsAndFiles/filesChanged.tsx

@@ -53,12 +53,12 @@ class FilesChanged extends AsyncView<Props, State> {
     };
   }
 
-  componentDidUpdate(prevProps: Props, prevContext: Record<string, any>) {
+  componentDidUpdate(prevProps: Props, prevState: State) {
     if (prevProps.activeReleaseRepo?.name !== this.props.activeReleaseRepo?.name) {
       this.remountComponent();
       return;
     }
-    super.componentDidUpdate(prevProps, prevContext);
+    super.componentDidUpdate(prevProps, prevState);
   }
 
   getEndpoints(): ReturnType<AsyncView['getEndpoints']> {

+ 13 - 6
static/app/views/releases/detail/index.tsx

@@ -92,7 +92,7 @@ class ReleasesDetail extends AsyncView<Props, State> {
     };
   }
 
-  componentDidUpdate(prevProps, prevContext: Record<string, any>) {
+  componentDidUpdate(prevProps: Props, prevState: State) {
     const {organization, params, location} = this.props;
 
     if (
@@ -103,7 +103,7 @@ class ReleasesDetail extends AsyncView<Props, State> {
         this.pickLocationQuery(location)
       )
     ) {
-      super.componentDidUpdate(prevProps, prevContext);
+      super.componentDidUpdate(prevProps, prevState);
     }
   }
 
@@ -227,9 +227,13 @@ class ReleasesDetail extends AsyncView<Props, State> {
   }
 }
 
+type ReleasesDetailContainerProps = Omit<Props, 'releaseMeta'>;
+type ReleasesDetailContainerState = {
+  releaseMeta: ReleaseMeta | null;
+} & AsyncComponent['state'];
 class ReleasesDetailContainer extends AsyncComponent<
-  Omit<Props, 'releaseMeta'>,
-  {releaseMeta: ReleaseMeta | null} & AsyncComponent['state']
+  ReleasesDetailContainerProps,
+  ReleasesDetailContainerState
 > {
   shouldReload = true;
 
@@ -250,7 +254,10 @@ class ReleasesDetailContainer extends AsyncComponent<
     this.removeGlobalDateTimeFromUrl();
   }
 
-  componentDidUpdate(prevProps, prevContext: Record<string, any>) {
+  componentDidUpdate(
+    prevProps: ReleasesDetailContainerProps,
+    prevState: ReleasesDetailContainerState
+  ) {
     const {organization, params} = this.props;
 
     this.removeGlobalDateTimeFromUrl();
@@ -258,7 +265,7 @@ class ReleasesDetailContainer extends AsyncComponent<
       prevProps.params.release !== params.release ||
       prevProps.organization.slug !== organization.slug
     ) {
-      super.componentDidUpdate(prevProps, prevContext);
+      super.componentDidUpdate(prevProps, prevState);
     }
   }
 

+ 2 - 2
static/app/views/settings/projectPlugins/details.tsx

@@ -40,8 +40,8 @@ type State = {
  *    PluginsStore
  */
 class ProjectPluginDetails extends AsyncView<Props, State> {
-  componentDidUpdate(prevProps: Props, prevContext: any) {
-    super.componentDidUpdate(prevProps, prevContext);
+  componentDidUpdate(prevProps: Props, prevState: State) {
+    super.componentDidUpdate(prevProps, prevState);
     if (prevProps.params.pluginId !== this.props.params.pluginId) {
       this.recordDetailsViewed();
     }