Просмотр исходного кода

ref(highlights): Prune some defaults to accomodate new UI (#81986)

With the new UI we're bringing back some icons beside where we show
highlights. This means that some of it will overlap needlessly. In this
PR I'm removing the defaults that will likely render better with icons
anyway, which actually allows us to do away with backend/frontend
specific highlights all together.
Leander Rodrigues 3 месяцев назад
Родитель
Сommit
bcb5596259
1 измененных файлов с 7 добавлено и 18 удалено
  1. 7 18
      src/sentry/issues/highlights.py

+ 7 - 18
src/sentry/issues/highlights.py

@@ -7,7 +7,7 @@ from drf_spectacular.utils import extend_schema_field
 from rest_framework import serializers
 from rest_framework import serializers
 
 
 from sentry.models.project import Project
 from sentry.models.project import Project
-from sentry.utils.platform_categories import BACKEND, FRONTEND, MOBILE
+from sentry.utils.platform_categories import MOBILE
 
 
 
 
 @extend_schema_field(field=OpenApiTypes.OBJECT)
 @extend_schema_field(field=OpenApiTypes.OBJECT)
@@ -35,33 +35,22 @@ class HighlightPreset(TypedDict):
     context: Mapping[str, list[str]]
     context: Mapping[str, list[str]]
 
 
 
 
-SENTRY_TAGS = ["handled", "level", "release", "environment"]
+DEFAULT_HIGHLIGHT_TAGS = ["handled", "level"]
+DEFAULT_HIGHLIGHT_CTX = {"trace": ["trace_id"]}
 
 
-BACKEND_HIGHLIGHTS: HighlightPreset = {
-    "tags": SENTRY_TAGS + ["url", "transaction", "status_code"],
-    "context": {"trace": ["trace_id"], "runtime": ["name", "version"]},
-}
-FRONTEND_HIGHLIGHTS: HighlightPreset = {
-    "tags": SENTRY_TAGS + ["url", "transaction", "browser", "user"],
-    "context": {"user": ["email"]},
-}
 MOBILE_HIGHLIGHTS: HighlightPreset = {
 MOBILE_HIGHLIGHTS: HighlightPreset = {
-    "tags": SENTRY_TAGS + ["mobile", "main_thread"],
-    "context": {"profile": ["profile_id"], "app": ["name"], "device": ["family"]},
+    "tags": DEFAULT_HIGHLIGHT_TAGS + ["mobile", "main_thread"],
+    "context": {**DEFAULT_HIGHLIGHT_CTX, "profile": ["profile_id"], "app": ["name"]},
 }
 }
 FALLBACK_HIGHLIGHTS: HighlightPreset = {
 FALLBACK_HIGHLIGHTS: HighlightPreset = {
-    "tags": SENTRY_TAGS,
-    "context": {"user": ["email"], "trace": ["trace_id"]},
+    "tags": DEFAULT_HIGHLIGHT_TAGS + ["url"],
+    "context": {**DEFAULT_HIGHLIGHT_CTX},
 }
 }
 
 
 
 
 def get_highlight_preset_for_project(project: Project) -> HighlightPreset:
 def get_highlight_preset_for_project(project: Project) -> HighlightPreset:
     if not project.platform or project.platform == "other":
     if not project.platform or project.platform == "other":
         return FALLBACK_HIGHLIGHTS
         return FALLBACK_HIGHLIGHTS
-    elif project.platform in FRONTEND:
-        return FRONTEND_HIGHLIGHTS
-    elif project.platform in BACKEND:
-        return BACKEND_HIGHLIGHTS
     elif project.platform in MOBILE:
     elif project.platform in MOBILE:
         return MOBILE_HIGHLIGHTS
         return MOBILE_HIGHLIGHTS
     return FALLBACK_HIGHLIGHTS
     return FALLBACK_HIGHLIGHTS