Browse Source

ref(integrations): Exit task if the external issue doesn't exist (#33871)

Fixes SENTRY-SR6
Leander Rodrigues 2 years ago
parent
commit
ba53e9d436
1 changed files with 5 additions and 2 deletions
  1. 5 2
      src/sentry/tasks/integrations/update_comment.py

+ 5 - 2
src/sentry/tasks/integrations/update_comment.py

@@ -12,9 +12,12 @@ from sentry.types.activity import ActivityType
     max_retries=5,
 )
 # TODO(jess): Add more retry exclusions once ApiClients have better error handling
-@retry(exclude=(ExternalIssue.DoesNotExist, Integration.DoesNotExist))
+@retry(exclude=(Integration.DoesNotExist))
 def update_comment(external_issue_id: int, user_id: int, group_note_id: int) -> None:
-    external_issue = ExternalIssue.objects.get(id=external_issue_id)
+    try:
+        external_issue = ExternalIssue.objects.get(id=external_issue_id)
+    except ExternalIssue.DoesNotExist:
+        return
     installation = external_issue.get_installation()
 
     if not should_comment_sync(installation, external_issue):