Browse Source

reemve ViewSampleSandboxExperiment (#31715)

We had an experiment to send folks to the Sandbox instead of creating a sample event from the empty project state. The experiment was a failure and the sandbox version is doing worse so we're removing it.
Stephen Cefali 3 years ago
parent
commit
b88fbf46e0
2 changed files with 19 additions and 59 deletions
  1. 19 53
      static/app/components/errorRobot.tsx
  2. 0 6
      static/app/data/experimentConfig.tsx

+ 19 - 53
static/app/components/errorRobot.tsx

@@ -5,13 +5,11 @@ import robotBackground from 'sentry-images/spot/sentry-robot.png';
 
 import {Client} from 'sentry/api';
 import Button from 'sentry/components/button';
-import DemoSandboxButton from 'sentry/components/demoSandboxButton';
 import Link from 'sentry/components/links/link';
 import {t, tct} from 'sentry/locale';
 import space from 'sentry/styles/space';
 import {Organization, Project} from 'sentry/types';
 import {defined} from 'sentry/utils';
-import {logExperiment} from 'sentry/utils/analytics';
 import withApi from 'sentry/utils/withApi';
 import CreateSampleEventButton from 'sentry/views/onboarding/createSampleEventButton';
 
@@ -44,12 +42,6 @@ class ErrorRobot extends Component<Props, State> {
 
   componentDidMount() {
     this.fetchData();
-    if (!this.props.org.features.includes('sandbox-kill-switch')) {
-      logExperiment({
-        key: 'ViewSampleSandboxExperiment',
-        organization: this.props.org,
-      });
-    }
   }
 
   async fetchData() {
@@ -86,52 +78,26 @@ class ErrorRobot extends Component<Props, State> {
     const {loading, error, sampleIssueId} = this.state;
     const {org, project, gradient} = this.props;
 
-    let sampleLink: React.ReactNode;
-    if (
-      org.experiments.ViewSampleSandboxExperiment &&
-      !org.features.includes('sandbox-kill-switch')
-    ) {
-      sampleLink = (
-        <DemoSandboxButton
-          scenario="oneIssue"
-          size="small"
-          priority="link"
-          clientData={{
-            cta: {
-              id: 'sample_issue',
-              title: t('Finish Setup'),
-              shortTitle: t('Setup'),
-              url: window.location.href,
-            },
-          }}
-        >
-          {t('See a Sample Event')}
-        </DemoSandboxButton>
+    const sampleLink =
+      project && (loading || error ? null : sampleIssueId) ? (
+        <p>
+          <Link to={`/${org.slug}/${project.slug}/issues/${sampleIssueId}/?sample`}>
+            {t('Or see your sample event')}
+          </Link>
+        </p>
+      ) : (
+        <p>
+          <CreateSampleEventButton
+            priority="link"
+            project={project}
+            source="issues_list"
+            disabled={!project}
+            title={!project ? t('Select a project to create a sample event') : undefined}
+          >
+            {t('Create a sample event')}
+          </CreateSampleEventButton>
+        </p>
       );
-    } else {
-      sampleLink =
-        project && (loading || error ? null : sampleIssueId) ? (
-          <p>
-            <Link to={`/${org.slug}/${project.slug}/issues/${sampleIssueId}/?sample`}>
-              {t('Or see your sample event')}
-            </Link>
-          </p>
-        ) : (
-          <p>
-            <CreateSampleEventButton
-              priority="link"
-              project={project}
-              source="issues_list"
-              disabled={!project}
-              title={
-                !project ? t('Select a project to create a sample event') : undefined
-              }
-            >
-              {t('Create a sample event')}
-            </CreateSampleEventButton>
-          </p>
-        );
-    }
 
     return (
       <ErrorRobotWrapper

+ 0 - 6
static/app/data/experimentConfig.tsx

@@ -43,12 +43,6 @@ export const experimentList = [
     parameter: 'exposed',
     assignments: [0, 1],
   },
-  {
-    key: 'ViewSampleSandboxExperiment',
-    type: ExperimentType.Organization,
-    parameter: 'exposed',
-    assignments: [0, 1],
-  },
 ] as const;
 
 export const experimentConfig = experimentList.reduce(