chore(tests) Remove low value acceptance tests (#56271)

Remove a handful of acceptance tests. My criteria for removal was one
of:

- test is skipped
- no feature specific data is inserted into the db.
- no assertions or waits for anything other than 'page loads'.

We could remove more tests if we only keep tests with assertions, but I
think there is some some value in having 'does it load' style checks for
key parts of the product.

tests/acceptance/test_create_project.py

@@ -29,13 +29,6 @@ class CreateProjectTest(AcceptanceTestCase):
         # After creating team, should end up in onboarding screen
         self.browser.wait_until(xpath='//div[text()="#new-team"]')
 
-    def test_many_teams(self):
-        self.team = self.create_team(organization=self.org, name="Mariachi Band")
-        self.team2 = self.create_team(organization=self.org, name="team two")
-
-        self.browser.get(self.path)
-        self.browser.wait_until_not(".loading")
-
     def test_select_correct_platform(self):
         self.create_team(organization=self.org, name="team three")
 

tests/acceptance/test_dashboard.py

@@ -1,90 +0,0 @@
-from datetime import datetime
-
-from django.utils import timezone
-
-from sentry.models import (
-    Deploy,
-    Environment,
-    GroupAssignee,
-    OnboardingTask,
-    OnboardingTaskStatus,
-    OrganizationOnboardingTask,
-    Release,
-    ReleaseProjectEnvironment,
-)
-from sentry.testutils.cases import AcceptanceTestCase, SnubaTestCase
-from sentry.testutils.silo import no_silo_test
-from sentry.utils.samples import load_data
-
-
-@no_silo_test(stable=True)
-class DashboardTest(AcceptanceTestCase, SnubaTestCase):
-    def setUp(self):
-        super().setUp()
-        release = Release.objects.create(organization_id=self.organization.id, version="1")
-
-        environment = Environment.objects.create(
-            organization_id=self.organization.id, name="production"
-        )
-
-        deploy = Deploy.objects.create(
-            environment_id=environment.id,
-            organization_id=self.organization.id,
-            release=release,
-            date_finished="2018-05-23",
-        )
-
-        ReleaseProjectEnvironment.objects.create(
-            project_id=self.project.id,
-            release_id=release.id,
-            environment_id=environment.id,
-            last_deploy_id=deploy.id,
-        )
-
-        self.login_as(self.user)
-        self.path = f"/organizations/{self.organization.slug}/projects/"
-
-    def create_sample_event(self):
-        self.init_snuba()
-
-        event_data = load_data("python")
-        event_data["event_id"] = "d964fdbd649a4cf8bfc35d18082b6b0e"
-        event_data["timestamp"] = 1452683305
-        event = self.store_event(
-            project_id=self.project.id, data=event_data, assert_no_errors=False
-        )
-        event.group.update(
-            first_seen=datetime(2018, 1, 12, 3, 8, 25, tzinfo=timezone.utc),
-            last_seen=datetime(2018, 1, 13, 3, 8, 25, tzinfo=timezone.utc),
-        )
-        GroupAssignee.objects.create(user_id=self.user.id, group=event.group, project=self.project)
-        OrganizationOnboardingTask.objects.create_or_update(
-            organization_id=self.project.organization_id,
-            task=OnboardingTask.FIRST_EVENT,
-            status=OnboardingTaskStatus.COMPLETE,
-        )
-        self.project.update(first_event=timezone.now())
-
-    def test_project_with_no_first_event(self):
-        self.project.update(first_event=None)
-        self.browser.get(self.path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
-        self.browser.wait_until_test_id("resources")
-        self.browser.wait_until(".echarts-for-react path", timeout=10000)
-
-    def test_one_issue(self):
-        self.create_sample_event()
-        self.browser.get(self.path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
-        self.browser.wait_until(".echarts-for-react path", timeout=100000)
-
-
-class EmptyDashboardTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.login_as(self.user)
-        self.path = f"/organizations/{self.organization.slug}/projects/"
-
-    def test_new_dashboard_empty(self):
-        self.browser.get(self.path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')

tests/acceptance/test_new_settings.py

@@ -1,21 +0,0 @@
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class NewSettingsTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user(
-            name="A Very Very Very Very Long Username", email="foo@example.com"
-        )
-        self.org = self.create_organization(
-            name="A Very Very Very Very Long Organization", owner=self.user
-        )
-        self.login_as(self.user)
-        self.path = "/settings/"
-
-    def test_settings_index(self):
-        with self.feature("organizations:onboarding"):
-            self.browser.get(self.path)
-            self.browser.wait_until_not('[data-test-id="loading-indicator"]')

tests/acceptance/test_organization_integration_directory.py

@@ -1,14 +0,0 @@
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class OrganizationIntegrationDirectoryTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.login_as(self.user)
-
-    def test_all_integrations_list(self):
-        path = f"/settings/{self.organization.slug}/integrations/"
-        self.browser.get(path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')

tests/acceptance/test_organization_sentry_app.py

@@ -1,91 +0,0 @@
-from unittest import mock
-
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-# from fixtures.page_objects.organization_integration_settings import (
-#     OrganizationIntegrationSettingsPage,
-# )
-
-
-@no_silo_test(stable=True)
-class OrganizationSentryAppAcceptanceTestCase(AcceptanceTestCase):
-    """
-    As a user, I can install and uninstall a Sentry App
-    """
-
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user("foo@example.com")
-        self.org = self.create_organization(name="Tesla", owner=None)
-        self.team = self.create_team(organization=self.org, name="Tesla Motors")
-        self.project = self.create_project(organization=self.org, teams=[self.team], name="Model S")
-        self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
-
-        self.sentry_app = self.create_sentry_app(
-            name="Tesla App", published=True, organization=self.org
-        )
-
-        self.login_as(self.user)
-
-        self.org_integration_settings_path = f"/settings/{self.org.slug}/integrations/"
-
-        self.provider = mock.Mock()
-        self.provider.key = "tesla-app"
-        self.provider.name = "Tesla App"
-
-    def load_page(self, url):
-        self.browser.get(url)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
-
-    # def test_install_sentry_app(self):
-    #     self.load_page(self.org_integration_settings_path)
-
-    #     org_settings_page = OrganizationIntegrationSettingsPage(browser=self.browser)
-
-    #     provider_element = org_settings_page.get_provider(self.provider)
-
-    #     # assert installation rather than upgrade button
-    #     assert provider_element.install_button.label == "Install"
-
-    #     provider_element.install_button.click()
-
-    #     install_selecter = '.modal-dialog [aria-label="Accept & Install"]'
-    #     self.browser.wait_until(install_selecter)
-    #     self.browser.click(install_selecter)
-
-    #     self.browser.wait_until(".ref-success")
-
-    #     # provider_element might be rerendered
-    #     provider_element = org_settings_page.get_provider(self.provider)
-
-    #     # assert we see the uninstall option
-    #     assert provider_element.install_button.label == "Uninstall"
-
-    # def test_uninstall_sentry_app(self):
-    #     # add the installation
-    #     self.installation = self.create_sentry_app_installation(
-    #         slug=self.sentry_app.slug, organization=self.org, user=self.user
-    #     )
-
-    #     self.load_page(self.org_integration_settings_path)
-
-    #     org_settings_page = OrganizationIntegrationSettingsPage(browser=self.browser)
-
-    #     provider_element = org_settings_page.get_provider(self.provider)
-
-    #     # assert we see the uninstall option
-    #     assert provider_element.install_button.label == "Uninstall"
-
-    #     provider_element.install_button.click()
-    #     self.browser.wait_until(org_settings_page.modal_selector)
-
-    #     self.browser.click('.modal-dialog [aria-label="Confirm"]')
-
-    #     self.browser.wait_until(".ref-success")
-
-    #     # provider_element might be rerendered
-    #     provider_element = org_settings_page.get_provider(self.provider)
-
-    #     # assert we see the install option now
-    #     assert provider_element.install_button.label == "Install"

tests/acceptance/test_organization_stats.py

@@ -1,23 +0,0 @@
-from django.utils import timezone
-
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class OrganizationStatsTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user("foo@example.com")
-        self.org = self.create_organization(name="Org Name")
-        self.team = self.create_team(name="Team Name", organization=self.org, members=[self.user])
-        self.project = self.create_project(
-            organization=self.org, teams=[self.team], name="Project Name"
-        )
-        self.login_as(self.user)
-        self.path = f"/organizations/{self.org.slug}/stats/"
-
-    def test_simple(self):
-        self.project.update(first_event=timezone.now())
-        self.browser.get(self.path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')

tests/acceptance/test_performance_span_summary.py

@@ -1,102 +0,0 @@
-from datetime import timedelta, timezone
-from unittest.mock import patch
-from urllib.parse import urlencode
-
-import pytest
-
-from fixtures.page_objects.base import BasePage
-from sentry.testutils.cases import AcceptanceTestCase, SnubaTestCase
-from sentry.testutils.helpers.datetime import before_now, iso_format
-from sentry.testutils.silo import no_silo_test
-from sentry.utils.samples import load_data
-
-FEATURES = {
-    "organizations:performance-span-histogram-view": True,
-    "organizations:performance-view": True,
-}
-
-
-@no_silo_test(stable=True)
-class PerformanceSpanSummaryTest(AcceptanceTestCase, SnubaTestCase):
-    def setUp(self):
-        super().setUp()
-        self.org = self.create_organization(owner=self.user, name="Rowdy Tiger")
-        self.team = self.create_team(
-            organization=self.org, name="Mariachi Band", members=[self.user]
-        )
-        self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
-        self.group = self.create_group(project=self.project)
-        self.login_as(self.user)
-        self.path = "/organizations/{}/performance/summary/spans/{}/?{}".format(
-            self.org.slug,
-            "django.middleware:" + "cd" * 8,
-            urlencode({"project": self.project.id, "transaction": "root transaction"}),
-        )
-        self.page = BasePage(self.browser)
-        self.min_ago = before_now(minutes=1).replace(microsecond=0)
-
-    def create_event(self, **kwargs):
-        if "span_id" not in kwargs:
-            kwargs["span_id"] = "a" * 16
-
-        if "start_timestamp" not in kwargs:
-            kwargs["start_timestamp"] = self.min_ago
-
-        if "timestamp" not in kwargs:
-            kwargs["timestamp"] = self.min_ago + timedelta(seconds=8)
-
-        if "trace_context" not in kwargs:
-            kwargs["trace_context"] = {
-                "op": "http.server",
-                "hash": "ab" * 8,
-                "exclusive_time": 4.0,
-            }
-
-        if "spans" not in kwargs:
-            kwargs["spans"] = [
-                {
-                    "same_process_as_parent": True,
-                    "parent_span_id": "a" * 16,
-                    "span_id": x * 16,
-                    "start_timestamp": iso_format(self.min_ago + timedelta(seconds=1)),
-                    "timestamp": iso_format(self.min_ago + timedelta(seconds=4)),
-                    "op": "django.middleware",
-                    "description": "middleware span",
-                    "hash": "cd" * 8,
-                    "exclusive_time": 3.0,
-                }
-                for x in ["b", "c"]
-            ] + [
-                {
-                    "same_process_as_parent": True,
-                    "parent_span_id": "a" * 16,
-                    "span_id": x * 16,
-                    "start_timestamp": iso_format(self.min_ago + timedelta(seconds=4)),
-                    "timestamp": iso_format(self.min_ago + timedelta(seconds=5)),
-                    "op": "django.middleware",
-                    "description": "middleware span",
-                    "hash": "cd" * 8,
-                    "exclusive_time": 1.0,
-                }
-                for x in ["d", "e", "f"]
-            ]
-
-        data = load_data("transaction", **kwargs)
-        data["transaction"] = "root transaction"
-        data["event_id"] = "c" * 32
-        data["contexts"]["trace"]["trace_id"] = "a" * 32
-
-        return self.store_event(data, project_id=self.project.id)
-
-    @pytest.mark.skip(reason="Has been flaky lately.")
-    @patch("django.utils.timezone.now")
-    def test_with_data(self, mock_now):
-        mock_now.return_value = before_now().replace(tzinfo=timezone.utc)
-
-        self.create_event()
-
-        with self.feature(FEATURES):
-            self.browser.get(self.path)
-            self.page.wait_until_loaded()
-            # Wait again for loaders inside the table
-            self.page.wait_until_loaded()

tests/acceptance/test_project_all_integrations_settings.py

@@ -1,20 +0,0 @@
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class ProjectAllIntegrationsSettingsTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user("foo@example.com")
-        self.org = self.create_organization(name="Rowdy Tiger", owner=None)
-        self.team = self.create_team(organization=self.org, name="Mariachi Band")
-        self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
-        self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
-
-        self.login_as(self.user)
-
-    def test_all_integrations_list(self):
-        path = f"/{self.org.slug}/{self.project.slug}/settings/plugins/"
-        self.browser.get(path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')

tests/acceptance/test_project_data_forwarding_settings.py

@@ -1,21 +0,0 @@
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class ProjectDataForwardingSettingsTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user("foo@example.com")
-        self.org = self.create_organization(name="Rowdy Tiger", owner=None)
-        self.team = self.create_team(organization=self.org, name="Mariachi Band")
-        self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
-        self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
-
-        self.login_as(self.user)
-        self.path = f"/{self.org.slug}/{self.project.slug}/settings/data-forwarding/"
-
-    def test_simple(self):
-        self.browser.get(self.path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')
-        self.browser.wait_until_test_id("data-forwarding-settings")

tests/acceptance/test_project_debug_symbols_settings.py

@@ -1,20 +0,0 @@
-from sentry.testutils.cases import AcceptanceTestCase
-from sentry.testutils.silo import no_silo_test
-
-
-@no_silo_test(stable=True)
-class ProjectSavedSearchesSettingsTest(AcceptanceTestCase):
-    def setUp(self):
-        super().setUp()
-        self.user = self.create_user("foo@example.com")
-        self.org = self.create_organization(name="Rowdy Tiger", owner=None)
-        self.team = self.create_team(organization=self.org, name="Mariachi Band")
-        self.project = self.create_project(organization=self.org, teams=[self.team], name="Bengal")
-        self.create_member(user=self.user, organization=self.org, role="owner", teams=[self.team])
-
-        self.login_as(self.user)
-
-    def test_saved_searches(self):
-        path = f"/{self.org.slug}/{self.project.slug}/settings/debug-symbols/"
-        self.browser.get(path)
-        self.browser.wait_until_not('[data-test-id="loading-indicator"]')