fix(metrics): skip dot escape for tags (#73371)

src/sentry/snuba/metrics/span_attribute_extraction.py

@@ -147,10 +147,8 @@ def _map_span_attribute_name(span_attribute: str) -> str:
         return span_attribute
 
     if span_attribute in _SENTRY_TAGS:
-        prefix = "span.sentry_tags"
-    else:
-        prefix = "span.data"
+        return f"span.sentry_tags.{span_attribute}"
 
     sanitized_span_attr = span_attribute.replace(".", "\\.")
 
-    return f"{prefix}.{sanitized_span_attr}"
+    return f"span.data.{sanitized_span_attr}"

tests/sentry/snuba/metrics/test_span_attribute_extraction.py

@@ -126,9 +126,8 @@ def test_sentry_tags():
             span_attribute=tag, type="d", unit="none", tags=set(), conditions=[]
         )
         metric_spec = convert_to_metric_spec(rule)
-        sanitized_tag = tag.replace(".", "\\.")
 
-        assert metric_spec["field"] == f"span.sentry_tags.{sanitized_tag}"
+        assert metric_spec["field"] == f"span.sentry_tags.{tag}"
         assert metric_spec["mri"] == f"d:custom/{tag}@none"