Browse Source

chore(alerts): Random small nits (#49524)

### Before
![Screenshot 2023-06-05 at 12 52 59
PM](https://github.com/getsentry/sentry/assets/1748388/374b1296-0c86-41eb-a427-702863449cd9)

### After
![Screenshot 2023-06-05 at 12 53 30
PM](https://github.com/getsentry/sentry/assets/1748388/99325b07-c515-4c0d-b255-df9ac305a75a)
Danny Lee 1 year ago
parent
commit
b63a8fd9a3

+ 1 - 1
src/sentry/api/bases/project.py

@@ -78,7 +78,7 @@ class ProjectSettingPermission(ProjectPermission):
 
 class ProjectAlertRulePermission(ProjectPermission):
     scope_map = {
-        "GET": ["project:read", "project:write", "project:admin", "alerts:read"],
+        "GET": ["project:read", "project:write", "project:admin", "alerts:read", "alerts:write"],
         "POST": ["project:write", "project:admin", "alerts:write"],
         "PUT": ["project:write", "project:admin", "alerts:write"],
         "DELETE": ["project:write", "project:admin", "alerts:write"],

+ 1 - 1
static/app/components/smartSearchBar/index.tsx

@@ -1891,7 +1891,7 @@ class SmartSearchBar extends Component<DefaultProps & Props, State> {
         </InputWrapper>
 
         <ActionsBar gap={0.5}>
-          {query !== '' && (
+          {query !== '' && !disabled && (
             <ActionButton
               onClick={this.clearSearch}
               icon={<IconClose size="xs" />}

+ 1 - 1
static/app/views/alerts/rules/metric/edit.tsx

@@ -42,7 +42,7 @@ class MetricRulesEdit extends AsyncView<Props, State> {
     const ruleName = rule?.name;
 
     return routeTitleGen(
-      ruleName ? t('Alert %s', ruleName) : '',
+      ruleName ? t('Alert - %s', ruleName) : '',
       organization.slug,
       false,
       project?.slug

+ 1 - 0
static/app/views/alerts/rules/metric/wizardField.tsx

@@ -152,6 +152,7 @@ export default function WizardField({
             <SelectControl
               value={selectedTemplate}
               options={menuOptions}
+              disabled={disabled}
               onChange={(option: MenuOption) => {
                 const template = AlertWizardRuleTemplates[option.value];