ref: remove fake Visual Snapshot required check (#45153)

this is no longer a required check

.github/workflows/acceptance.yml

@@ -160,19 +160,3 @@ jobs:
           api-token: ${{ secrets.VISUAL_SNAPSHOT_SECRET }}
           gcs-bucket: 'sentry-visual-snapshots'
           gcp-service-account-key: ${{ secrets.SNAPSHOT_GOOGLE_SERVICE_ACCOUNT_KEY }}
-
-  # "Visual Snapshot" is a required check, so we either skip the visual tests
-  # and need to post a status passing OR we run the visual tests and let the
-  # visual snapshot service post a status.
-  #
-  # This handles the skip case and creates a status we skip acceptance tests.
-  fake-visual-snapshot:
-    name: Visual Snapshot
-    needs: [files-changed]
-    # Opposite condition to "triggers visual snapshot" required check
-    if: needs.files-changed.outputs.acceptance != 'true'
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Sentaur attack
-        run: |
-          echo "This check creates a Visual Snapshot to satisfy Github required checks when we skip acceptance tests."