Browse Source

perf(serializer): Optimize Organization validate_slug query

Matt Robenolt 7 years ago
parent
commit
b09b975c03
1 changed files with 4 additions and 1 deletions
  1. 4 1
      src/sentry/api/endpoints/organization_details.py

+ 4 - 1
src/sentry/api/endpoints/organization_details.py

@@ -78,7 +78,10 @@ class OrganizationSerializer(serializers.Serializer):
 
     def validate_slug(self, attrs, source):
         value = attrs[source]
-        if Organization.objects.filter(slug=value).exclude(id=self.context['organization'].id):
+        qs = Organization.objects.filter(
+            slug=value,
+        ).exclude(id=self.context['organization'].id)
+        if qs.exists():
             raise serializers.ValidationError('The slug "%s" is already in use.' % (value, ))
         return attrs