Browse Source

chore(perf): Remove references to legacy APDEX, USER_MISERY descriptions (#32125)

Remove references to legacy apdex.
Shruthi 3 years ago
parent
commit
ab52cc0716

+ 5 - 16
static/app/views/performance/data.tsx

@@ -32,7 +32,6 @@ export const COLUMN_TITLES = [
 ];
 
 export enum PERFORMANCE_TERM {
-  APDEX = 'apdex',
   TPM = 'tpm',
   THROUGHPUT = 'throughput',
   FAILURE_RATE = 'failureRate',
@@ -44,11 +43,10 @@ export enum PERFORMANCE_TERM {
   FCP = 'fcp',
   FID = 'fid',
   CLS = 'cls',
-  USER_MISERY = 'userMisery',
   STATUS_BREAKDOWN = 'statusBreakdown',
   DURATION_DISTRIBUTION = 'durationDistribution',
-  USER_MISERY_NEW = 'userMiseryNew',
-  APDEX_NEW = 'apdexNew',
+  USER_MISERY = 'userMisery',
+  APDEX = 'apdex',
   APP_START_COLD = 'appStartCold',
   APP_START_WARM = 'appStartWarm',
   SLOW_FRAMES = 'slowFrames',
@@ -66,7 +64,7 @@ export type TooltipOption = SelectValue<string> & {
 export function getAxisOptions(organization: Organization): TooltipOption[] {
   return [
     {
-      tooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW),
+      tooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX),
       value: 'apdex()',
       label: t('Apdex'),
     },
@@ -318,10 +316,6 @@ export function getMobileAxisOptions(organization: Organization): AxisOption[] {
 type TermFormatter = (organization: Organization) => string;
 
 export const PERFORMANCE_TERMS: Record<PERFORMANCE_TERM, TermFormatter> = {
-  apdex: () =>
-    t(
-      'Apdex is the ratio of both satisfactory and tolerable response times to all response times. To adjust the tolerable threshold, go to performance settings.'
-    ),
   tpm: () => t('TPM is the number of recorded transaction events per minute.'),
   throughput: () =>
     t('Throughput is the number of recorded transaction events per minute.'),
@@ -345,11 +339,6 @@ export const PERFORMANCE_TERMS: Record<PERFORMANCE_TERM, TermFormatter> = {
     t(
       'Cumulative layout shift (CLS) is a web vital measuring unexpected visual shifting a user experiences.'
     ),
-  userMisery: organization =>
-    t(
-      "User Misery is a score that represents the number of unique users who have experienced load times 4x your organization's apdex threshold of %sms.",
-      organization.apdexThreshold
-    ),
   statusBreakdown: () =>
     t(
       'The breakdown of transaction statuses. This may indicate what type of failure it is.'
@@ -358,11 +347,11 @@ export const PERFORMANCE_TERMS: Record<PERFORMANCE_TERM, TermFormatter> = {
     t(
       'Distribution buckets counts of transactions at specifics times for your current date range'
     ),
-  userMiseryNew: () =>
+  userMisery: () =>
     t(
       "User Misery is a score that represents the number of unique users who have experienced load times 4x the project's configured threshold. Adjust project threshold in project performance settings."
     ),
-  apdexNew: () =>
+  apdex: () =>
     t(
       'Apdex is the ratio of both satisfactory and tolerable response times to all response times. To adjust the tolerable threshold, go to project performance settings.'
     ),

+ 1 - 1
static/app/views/performance/landing/utils.tsx

@@ -206,7 +206,7 @@ export const vitalCardDetails = (
     },
     'apdex()': {
       title: t('Apdex'),
-      tooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW),
+      tooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX),
       formatter: value => formatFloat(value, 4),
     },
     'p75(measurements.frames_slow_rate)': {

+ 1 - 1
static/app/views/performance/landing/widgets/widgetDefinitions.tsx

@@ -157,7 +157,7 @@ export const WIDGET_DEFINITIONS: ({
   },
   [PerformanceWidgetSetting.APDEX_AREA]: {
     title: t('Apdex'),
-    titleTooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW),
+    titleTooltip: getTermHelp(organization, PERFORMANCE_TERM.APDEX),
     fields: ['apdex()'],
     dataType: GenericPerformanceWidgetDataType.area,
     chartColor: WIDGET_PALETTE[4],

+ 1 - 1
static/app/views/performance/transactionSummary/transactionOverview/sidebarCharts.tsx

@@ -100,7 +100,7 @@ function SidebarCharts({
           {t('Apdex')}
           <QuestionTooltip
             position="top"
-            title={getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW)}
+            title={getTermHelp(organization, PERFORMANCE_TERM.APDEX)}
             size="sm"
           />
         </ChartTitle>

+ 1 - 1
static/app/views/performance/transactionSummary/transactionOverview/userStats.tsx

@@ -108,7 +108,7 @@ function UserStats({
         {t('User Misery')}
         <QuestionTooltip
           position="top"
-          title={getTermHelp(organization, PERFORMANCE_TERM.USER_MISERY_NEW)}
+          title={getTermHelp(organization, PERFORMANCE_TERM.USER_MISERY)}
           size="sm"
         />
       </SectionHeading>

+ 1 - 1
static/app/views/projectDetail/projectCharts.tsx

@@ -292,7 +292,7 @@ class ProjectCharts extends Component<Props, State> {
               {displayMode === DisplayModes.APDEX && (
                 <ProjectBaseEventsChart
                   title={t('Apdex')}
-                  help={getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW)}
+                  help={getTermHelp(organization, PERFORMANCE_TERM.APDEX)}
                   query={new MutableSearch([
                     'event.type:transaction',
                     query ?? '',

+ 1 - 1
static/app/views/projectDetail/projectScoreCards/projectApdexScoreCard.tsx

@@ -116,7 +116,7 @@ class ProjectApdexScoreCard extends AsyncComponent<Props, State> {
 
   get cardHelp() {
     const {organization} = this.props;
-    const baseHelp = getTermHelp(organization, PERFORMANCE_TERM.APDEX_NEW);
+    const baseHelp = getTermHelp(organization, PERFORMANCE_TERM.APDEX);
 
     if (this.trend) {
       return baseHelp + t(' This shows how it has changed since the last period.');