Просмотр исходного кода

ref(insights): pass in organization to getTransactionSummaryBaseUrl (#84229)

As part of #84021 , we have to update the route for the transaction
summary to be `/insights/summary` instead of `/performance/summary`.
This route change should be behind a flag.

We have a helper function that returns the transaction summary url
`getTransactionSummaryBaseUrl`, this function makes the most sense to
add the conditional that returns either /insights/summary or
/performance/summary. However the helper function does not have access
to organization features.

This PR replaces the `orgSlug` parameter with the `organization`
parameter, that way we can access `organization.features`. In another PR
we can use this parameter to add the conditional on the feature flag.
Dominik Buszowiecki 1 месяц назад
Родитель
Сommit
a9689fde34

+ 1 - 1
static/app/components/discover/transactionsList.tsx

@@ -318,7 +318,7 @@ class _TransactionsList extends Component<Props> {
               <LinkButton
                 onClick={handleOpenAllEventsClick}
                 to={this.generatePerformanceTransactionEventsView().getPerformanceTransactionEventsViewUrlTarget(
-                  organization.slug,
+                  organization,
                   {
                     showTransactions: mapShowTransactionToPercentile(showTransactions),
                     breakdown,

+ 1 - 1
static/app/components/events/contexts/knownContext/trace.tsx

@@ -148,7 +148,7 @@ export function getTraceContextData({
           }
 
           const link = transactionSummaryRouteWithQuery({
-            orgSlug: organization.slug,
+            organization,
             transaction: transactionName,
             projectID: event.projectID,
             query: {},

+ 2 - 2
static/app/components/events/eventCustomPerformanceMetrics.tsx

@@ -135,7 +135,7 @@ export function EventCustomPerformanceMetric({
     switch (source) {
       case EventDetailPageSource.PERFORMANCE:
         return transactionSummaryRouteWithQuery({
-          orgSlug: organization.slug,
+          organization,
           transaction: event.title,
           projectID: event.projectID,
           query: {query},
@@ -231,7 +231,7 @@ export function TraceEventCustomPerformanceMetric({
     switch (source) {
       case EventDetailPageSource.PERFORMANCE:
         return transactionSummaryRouteWithQuery({
-          orgSlug: organization.slug,
+          organization,
           transaction: event.title,
           projectID: event.projectID,
           query: {query},

+ 1 - 1
static/app/components/events/eventStatisticalDetector/aggregateSpanDiff.tsx

@@ -203,7 +203,7 @@ function AggregateSpanDiff({event, project}: AggregateSpanDiffProps) {
         defaultValue: t('(unnamed span)'),
         link: (dataRow: any) => ({
           target: spanDetailsRouteWithQuery({
-            orgSlug: organization.slug,
+            organization,
             spanSlug: {op: dataRow.operation, group: dataRow.group},
             transaction,
             projectID: project.id,

+ 1 - 1
static/app/components/events/eventStatisticalDetector/eventRegressionSummary.tsx

@@ -58,7 +58,7 @@ export function getKeyValueListData(
     case IssueType.PERFORMANCE_DURATION_REGRESSION:
     case IssueType.PERFORMANCE_ENDPOINT_REGRESSION: {
       const target = transactionSummaryRouteWithQuery({
-        orgSlug: organization.slug,
+        organization,
         transaction: evidenceData.transaction,
         query: {},
         trendFunction: 'p95',

+ 1 - 1
static/app/components/events/eventStatisticalDetector/regressionMessage.tsx

@@ -70,7 +70,7 @@ function EventStatisticalDetectorRegressedPerformanceMessage({
   });
 
   const transactionSummaryLink = transactionSummaryRouteWithQuery({
-    orgSlug: organization.slug,
+    organization,
     transaction,
     query: {},
     trendFunction: 'p95',

+ 1 - 1
static/app/components/events/eventTags/eventTagContent.tsx

@@ -59,7 +59,7 @@ function EventTagsContent({
           <EventTagsValue
             tag={tag}
             meta={meta?.value?.['']}
-            streamPath={`${getTransactionSummaryBaseUrl(organization.slug)}/`}
+            streamPath={`${getTransactionSummaryBaseUrl(organization)}/`}
             locationSearch={`?${qs.stringify({
               project: projectId,
               transaction: value,

+ 2 - 2
static/app/components/events/eventTags/eventTagsTreeRow.tsx

@@ -220,7 +220,7 @@ function EventTagsTreeRowDropdown({
           to:
             originalTag.key === 'transaction'
               ? {
-                  pathname: `${getTransactionSummaryBaseUrl(organization.slug)}/`,
+                  pathname: `${getTransactionSummaryBaseUrl(organization)}/`,
                   query: {
                     project: event.projectID,
                     transaction: content.value,
@@ -297,7 +297,7 @@ function EventTagsTreeValue({
         transaction: content.value,
         referrer,
       });
-      const transactionDestination = `${getTransactionSummaryBaseUrl(organization.slug)}/?${transactionQuery}`;
+      const transactionDestination = `${getTransactionSummaryBaseUrl(organization)}/?${transactionQuery}`;
       tagValue = (
         <TagLinkText>
           <Link to={transactionDestination}>{content.value}</Link>

+ 2 - 2
static/app/components/events/interfaces/performance/spanEvidenceKeyValueList.tsx

@@ -245,7 +245,7 @@ function MainThreadFunctionEvidence({
 
     if (evidenceData.transactionName) {
       const transactionSummaryLocation = transactionSummaryRouteWithQuery({
-        orgSlug: organization.slug,
+        organization,
         projectID: event.projectID,
         transaction: evidenceData.transactionName,
         query: {},
@@ -466,7 +466,7 @@ const makeTransactionNameRow = (
   projectSlug?: string
 ) => {
   const transactionSummaryLocation = transactionSummaryRouteWithQuery({
-    orgSlug: organization.slug,
+    organization,
     projectID: event.projectID,
     transaction: event.title,
     query: {},

+ 2 - 2
static/app/components/events/interfaces/spans/newTraceDetailsSpanDetails.tsx

@@ -208,7 +208,7 @@ function NewTraceDetailsSpanDetail(props: SpanDetailProps) {
           }
 
           const target = transactionSummaryRouteWithQuery({
-            orgSlug: props.organization.slug,
+            organization: props.organization,
             transaction: transactionResult.transaction,
             query: omit(location.query, Object.values(PAGE_URL_PARAM)),
             projectID: String(childTransaction.value.project_id),
@@ -267,7 +267,7 @@ function NewTraceDetailsSpanDetail(props: SpanDetailProps) {
         <LinkButton
           size="xs"
           to={spanDetailsRouteWithQuery({
-            orgSlug: organization.slug,
+            organization,
             transaction: transactionName,
             query: location.query,
             spanSlug: {op: props.node.value.op, group: groupHash},

Некоторые файлы не были показаны из-за большого количества измененных файлов