ref: remove pyright (#51350)

this makes it more difficult to adopt type checking when you have to
satisfy two different type checkers. we may add pyright back later




<!-- Describe your PR here. -->

.pre-commit-config.yaml

@@ -51,15 +51,6 @@ repos:
       language: python
       files: requirements-.*\.txt$
       additional_dependencies: [packaging==21.3]
-    - id: pyright
-      name: pyright
-      entry: pyright
-      language: node
-      files: ^src/
-      types: [ python ]
-      require_serial: true
-      additional_dependencies: [ "pyright@1.1.311" ]
-      args: [ '--project', 'config/pyrightconfig-commithook.json' ]
 
 -   repo: https://github.com/python-jsonschema/check-jsonschema
     rev: 0.21.0

config/pyrightconfig-commithook.json

@@ -1,15 +0,0 @@
-{
-  "include": [
-    "src"
-  ],
-  "extraPaths": ["src"],
-  "exclude": [
-    ".volta/**"
-  ],
-
-  "stubPath": "fixtures/stubs-for-mypy",
-  "typeCheckingMode": "off",
-  "reportMissingImports": "none",
-  "reportUndefinedVariable": "none",
-  "reportUnboundVariable": "error"
-}

src/sentry/models/commit.py

@@ -23,7 +23,7 @@ if TYPE_CHECKING:
 
 
 class CommitManager(BaseManager):
-    def get_for_release(self, release: Release) -> QuerySet[Commit]:  # pyright: ignore
+    def get_for_release(self, release: Release) -> QuerySet[Commit]:
         return (
             self.filter(releasecommit__release=release)
             .order_by("-releasecommit__order")

src/sentry/models/integrations/external_issue.py

@@ -43,7 +43,7 @@ class ExternalIssueManager(BaseManager):
 
     def get_linked_issues(
         self, event: Event, integration: RpcIntegration
-    ) -> QuerySet[ExternalIssue]:  # pyright: ignore
+    ) -> QuerySet[ExternalIssue]:
         from sentry.models import GroupLink
 
         return self.filter(

src/sentry/models/integrations/sentry_app_installation.py

@@ -43,7 +43,7 @@ class SentryAppInstallationForProviderManager(ParanoidManager):
     def get_by_api_token(self, token_id: str) -> QuerySet:
         return self.filter(status=SentryAppInstallationStatus.INSTALLED, api_token_id=token_id)
 
-    def get_projects(self, token: ApiToken) -> QuerySet[Project]:  # pyright: ignore
+    def get_projects(self, token: ApiToken) -> QuerySet[Project]:
         from sentry.models import Project, SentryAppInstallationToken
 
         try:

src/sentry/nodestore/base.py

@@ -185,7 +185,7 @@ class NodeStorage(local, Service):
             }
             if subkey is None:
                 self._set_cache_items(items)
-                items.update(cache_items)  # pyright: ignore
+                items.update(cache_items)
 
             span.set_tag("result", "from_service")
             span.set_tag("found", len(items))

src/sentry/similarity/features.py

@@ -138,9 +138,7 @@ class FeatureSet:
                     if features:
                         items.append((self.aliases[label], features))
 
-        return self.index.record(
-            scope, key, items, timestamp=int(to_timestamp(event.datetime))  # pyright: ignore
-        )
+        return self.index.record(scope, key, items, timestamp=int(to_timestamp(event.datetime)))
 
     def classify(self, events, limit=None, thresholds=None):
         if not events:
@@ -187,7 +185,7 @@ class FeatureSet:
                 scope,
                 items,
                 limit=limit,
-                timestamp=int(to_timestamp(event.datetime)),  # pyright: ignore
+                timestamp=int(to_timestamp(event.datetime)),
             )
         ]
 

src/sentry/tasks/assemble.py

@@ -165,7 +165,7 @@ def assemble_dif(project_id, name, checksum, chunks, debug_id=None, **kwargs):
         )
     finally:
         if delete_file:
-            file.delete()  # pyright: ignore
+            file.delete()
 
 
 class AssembleArtifactsError(Exception):

src/sentry/tasks/commit_context.py

@@ -369,7 +369,7 @@ def process_commit_context(
         logger.info(
             "process_commit_context.max_retries_exceeded",
             extra={
-                **basic_logging_details,  # pyright: ignore
+                **basic_logging_details,
                 "reason": "max_retries_exceeded",
             },
         )