Browse Source

chore(perf): Move "Requests" module under the Spans UI feature flag (#69775)

This is effectively the same as a full graduation to GA, since the spans
UI flag is an AM2 plan handler that also checks ST rollout options.
After this, I can delete the flag.
George Gritsouk 10 months ago
parent
commit
a547c8095d

+ 1 - 2
static/app/components/sidebar/index.tsx

@@ -250,7 +250,6 @@ function Sidebar() {
         // If Database View or Web Vitals View is enabled, show a Performance accordion with a Database and/or Web Vitals sub-item
         if (
           organization.features.includes('spans-first-ui') ||
-          organization.features.includes('performance-http-view') ||
           organization.features.includes('performance-cache-view') ||
           organization.features.includes('performance-queues-view')
         ) {
@@ -278,7 +277,7 @@ function Sidebar() {
                   icon={<SubitemDot collapsed />}
                 />
               </Feature>
-              <Feature features="performance-http-view" organization={organization}>
+              <Feature features="spans-first-ui" organization={organization}>
                 <SidebarItem
                   {...sidebarItemProps}
                   label={

+ 1 - 1
static/app/views/performance/http/httpDomainSummaryPage.tsx

@@ -349,7 +349,7 @@ function LandingPageWithProviders() {
     <ModulePageProviders
       baseURL="/performance/http"
       title={[t('Performance'), MODULE_TITLE, t('Domain Summary')].join(' — ')}
-      features="performance-http-view"
+      features="spans-first-ui"
     >
       <HTTPDomainSummaryPage />
     </ModulePageProviders>

+ 1 - 1
static/app/views/performance/http/httpLandingPage.tsx

@@ -243,7 +243,7 @@ function LandingPageWithProviders() {
     <ModulePageProviders
       title={[t('Performance'), MODULE_TITLE].join(' — ')}
       baseURL="/performance/http"
-      features="performance-http-view"
+      features="spans-first-ui"
     >
       <HTTPLandingPage />
     </ModulePageProviders>

+ 0 - 4
static/app/views/performance/landing/views/allTransactionsView.tsx

@@ -48,11 +48,7 @@ export function AllTransactionsView(props: BasePerformanceViewProps) {
     if (props.organization.features.includes('spans-first-ui')) {
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_RELATED_ISSUES);
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_CHANGED);
-    }
-    if (props.organization.features.includes('performance-http-view')) {
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
-    }
-    if (props.organization.features.includes('spans-first-ui')) {
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_SPENT_DB_QUERIES);
     } else {
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_CHANGED);

+ 1 - 4
static/app/views/performance/landing/views/backendView.tsx

@@ -69,11 +69,8 @@ export function BackendView(props: BasePerformanceViewProps) {
       doubleChartRowCharts.push(PerformanceWidgetSetting.MOST_CHANGED);
     }
 
-    if (props.organization.features.includes('performance-http-view')) {
-      doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
-    }
-
     if (props.organization.features.includes('spans-first-ui')) {
+      doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
       doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_SPENT_DB_QUERIES);
     }
   } else {

+ 1 - 4
static/app/views/performance/landing/views/frontendOtherView.tsx

@@ -37,11 +37,8 @@ export function FrontendOtherView(props: BasePerformanceViewProps) {
     PerformanceWidgetSetting.SLOW_RESOURCE_OPS,
   ];
 
-  if (props.organization.features.includes('performance-http-view')) {
-    doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
-  }
-
   if (props.organization.features.includes('spans-first-ui')) {
+    doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
     doubleChartRowCharts.unshift(PerformanceWidgetSetting.MOST_TIME_CONSUMING_RESOURCES);
   }
 

+ 1 - 1
static/app/views/performance/landing/views/mobileView.tsx

@@ -61,7 +61,7 @@ export function MobileView(props: BasePerformanceViewProps) {
     );
   }
 
-  if (props.organization.features.includes('performance-http-view')) {
+  if (props.organization.features.includes('spans-first-ui')) {
     doubleRowAllowedCharts.push(PerformanceWidgetSetting.MOST_TIME_CONSUMING_DOMAINS);
   }
   return (