ref(feature-flag): Enable images-loaded-v2 by default - GA (#25480)

Flips the feature flag default and fixes tests to keep working.  The
symbolicator tests are now flag-independent as the functionality
is already tested in the symbolicator repo, only the fact that enabling
the flag enables the integration between sentry and symbolicator
needs to be tested here.

Co-authored-by: Floris Bruynooghe <flub@sentry.io>

src/sentry/conf/server.py

@@ -988,7 +988,7 @@ SENTRY_FEATURES = {
     # Enable the new alert details ux design
     "organizations:alert-details-redesign": False,
     # Enable the new images loaded design and features
-    "organizations:images-loaded-v2": False,
+    "organizations:images-loaded-v2": True,
     # Enable teams to have ownership of alert rules
     "organizations:team-alerts-ownership": False,
     # Enable the new alert creation wizard

tests/sentry/api/serializers/test_organization.py

@@ -27,6 +27,7 @@ class OrganizationSerializerTest(TestCase):
             "discover-query",
             "event-attachments",
             "event-attachments-viewer",
+            "images-loaded-v2",
             "integrations-alert-rule",
             "integrations-chat-unfurl",
             "integrations-event-hooks",

tests/symbolicator/test_payload_full.py

@@ -104,7 +104,8 @@ class SymbolicatorResolvingIntegrationTest(RelayStoreHelper, TransactionTestCase
         assert response.status_code == 201, response.content
         assert len(response.data) == 1
 
-        event = self.post_and_retrieve_event(REAL_RESOLVING_EVENT_DATA)
+        with self.feature({"organizations:images-loaded-v2": False}):
+            event = self.post_and_retrieve_event(REAL_RESOLVING_EVENT_DATA)
 
         assert event.data["culprit"] == "main"
         insta_snapshot_stacktrace_data(self, event.data)
@@ -163,14 +164,16 @@ class SymbolicatorResolvingIntegrationTest(RelayStoreHelper, TransactionTestCase
             "timestamp": iso_format(before_now(seconds=1)),
         }
 
-        event = self.post_and_retrieve_event(event_data)
+        with self.feature({"organizations:images-loaded-v2": False}):
+            event = self.post_and_retrieve_event(event_data)
         assert event.data["culprit"] == "main"
         insta_snapshot_stacktrace_data(self, event.data)
 
     def test_missing_dsym(self):
         self.login_as(user=self.user)
 
-        event = self.post_and_retrieve_event(REAL_RESOLVING_EVENT_DATA)
+        with self.feature({"organizations:images-loaded-v2": False}):
+            event = self.post_and_retrieve_event(REAL_RESOLVING_EVENT_DATA)
         assert event.data["culprit"] == "unknown"
         insta_snapshot_stacktrace_data(self, event.data)
 
@@ -180,7 +183,8 @@ class SymbolicatorResolvingIntegrationTest(RelayStoreHelper, TransactionTestCase
         payload = dict(project=self.project.id, **REAL_RESOLVING_EVENT_DATA)
         del payload["debug_meta"]
 
-        event = self.post_and_retrieve_event(payload)
+        with self.feature({"organizations:images-loaded-v2": False}):
+            event = self.post_and_retrieve_event(payload)
         assert event.data["culprit"] == "unknown"
         insta_snapshot_stacktrace_data(self, event.data)