Browse Source

ref(page-filters): Move page filters bar to the left in Issues Index (#32930)

* ref(page-filters): Move page filters bar to the left in Issues Index

* fix(page-filters): Keep DropdownsWrapper on the right side
Vu Luong 3 years ago
parent
commit
a0c9bf2108
1 changed files with 9 additions and 20 deletions
  1. 9 20
      static/app/views/issueList/filters.tsx

+ 9 - 20
static/app/views/issueList/filters.tsx

@@ -66,6 +66,13 @@ function IssueListFilters({
         hasPageFilters={hasPageFilters}
         hasIssuePercentDisplay={hasIssuePercentDisplay}
       >
+        {hasPageFilters && (
+          <PageFilterBar>
+            <ProjectPageFilter />
+            <EnvironmentPageFilter alignDropdown="right" />
+            <DatePageFilter alignDropdown="right" />
+          </PageFilterBar>
+        )}
         <IssueListSearchBar
           organization={organization}
           query={query || ''}
@@ -78,14 +85,7 @@ function IssueListFilters({
           savedSearch={savedSearch}
           onSidebarToggle={onSidebarToggle}
         />
-
-        {hasPageFilters ? (
-          <PageFilterBar>
-            <ProjectPageFilter />
-            <EnvironmentPageFilter alignDropdown="right" />
-            <DatePageFilter alignDropdown="right" />
-          </PageFilterBar>
-        ) : (
+        {!hasPageFilters && (
           <DropdownsWrapper hasIssuePercentDisplay={hasIssuePercentDisplay}>
             {hasIssuePercentDisplay && (
               <IssueListDisplayOptions
@@ -144,18 +144,7 @@ const SearchContainer = styled('div')<{
 
   ${p =>
     p.hasPageFilters
-      ? `
-    grid-template-columns: 1fr 32rem;
-
-    @media (max-width: ${p.theme.breakpoints[2]}) {
-      grid-template-columns: 1fr 28rem;
-    }
-
-    @media (max-width: ${p.theme.breakpoints[1]}) {
-      grid-template-columns: 1fr 24rem;
-    }
-
-  `
+      ? `grid-template-columns: minmax(0, max-content) minmax(20rem, 1fr);`
       : `
     @media (min-width: ${p.theme.breakpoints[p.hasIssuePercentDisplay ? 1 : 0]}) {
       grid-template-columns: 1fr auto;