feat(issue-priority): Rename Priority sort to Trends in UI (#65210)

Part 2/4 for https://github.com/getsentry/sentry/issues/65208:

Rename the Priority sort option to Trends to avoid confusing it with the
new Group.priority column and feature. This PR changes the frontend
option to use trends. The frontend will now send 'trends' for the sort
type. The backend knows how to handle this and will convert 'priority'
to trends to remain compatible with saved searches.

static/app/components/modals/savedSearchModal/createSavedSearchModal.spec.tsx

@@ -83,7 +83,7 @@ describe('CreateSavedSearchModal', function () {
     await userEvent.click(screen.getByRole('textbox', {name: /filter issues/i}));
     await userEvent.paste('is:resolved');
 
-    await selectEvent.select(screen.getByText('Last Seen'), 'Priority');
+    await selectEvent.select(screen.getByText('Last Seen'), 'Trends');
     await userEvent.click(screen.getByRole('button', {name: 'Save'}));
 
     await waitFor(() => {
@@ -93,7 +93,7 @@ describe('CreateSavedSearchModal', function () {
           data: {
             name: 'new search name',
             query: 'is:resolved',
-            sort: IssueSortOptions.PRIORITY,
+            sort: IssueSortOptions.TRENDS,
             type: 0,
             visibility: SavedSearchVisibility.OWNER,
           },

static/app/components/modals/savedSearchModal/createSavedSearchModal.tsx

@@ -23,7 +23,7 @@ function validateSortOption({sort}: {sort?: string}) {
   const sortOptions = [
     IssueSortOptions.DATE,
     IssueSortOptions.NEW,
-    IssueSortOptions.PRIORITY,
+    IssueSortOptions.TRENDS,
     IssueSortOptions.FREQ,
     IssueSortOptions.USER,
   ];

static/app/components/modals/savedSearchModal/editSavedSearchModal.spec.tsx

@@ -57,7 +57,7 @@ describe('EditSavedSearchModal', function () {
         id: 'saved-search-id',
         name: 'test',
         query: 'is:unresolved browser:firefox',
-        sort: IssueSortOptions.PRIORITY,
+        sort: IssueSortOptions.TRENDS,
         visibility: SavedSearchVisibility.OWNER,
       },
     });
@@ -70,7 +70,7 @@ describe('EditSavedSearchModal', function () {
     await userEvent.clear(screen.getByRole('textbox', {name: /filter issues/i}));
     await userEvent.paste('test');
 
-    await selectEvent.select(screen.getByText('Last Seen'), 'Priority');
+    await selectEvent.select(screen.getByText('Last Seen'), 'Trends');
 
     await selectEvent.select(screen.getByText('Only me'), 'Users in my organization');
 
@@ -98,7 +98,7 @@ describe('EditSavedSearchModal', function () {
         id: 'saved-search-id',
         name: 'test',
         query: 'is:unresolved browser:firefox',
-        sort: IssueSortOptions.PRIORITY,
+        sort: IssueSortOptions.TRENDS,
         visibility: SavedSearchVisibility.OWNER,
       },
     });
@@ -118,7 +118,7 @@ describe('EditSavedSearchModal', function () {
     await userEvent.clear(screen.getByTestId('smart-search-input'));
     await userEvent.paste('test');
 
-    await selectEvent.select(screen.getByText('Last Seen'), 'Priority');
+    await selectEvent.select(screen.getByText('Last Seen'), 'Trends');
 
     // Hovering over the visibility dropdown shows disabled reason
     await userEvent.hover(screen.getByText(/only me/i));

static/app/components/modals/savedSearchModal/savedSearchModalContent.tsx

@@ -24,7 +24,7 @@ export function SavedSearchModalContent({organization}: SavedSearchModalContentP
   const sortOptions = [
     IssueSortOptions.DATE,
     IssueSortOptions.NEW,
-    IssueSortOptions.PRIORITY,
+    IssueSortOptions.TRENDS,
     IssueSortOptions.FREQ,
     IssueSortOptions.USER,
   ];

static/app/views/dashboards/datasetConfig/issues.tsx

@@ -75,7 +75,7 @@ function getTableSortOptions(_organization: Organization, _widgetQuery: WidgetQu
   const sortOptions = [
     IssueSortOptions.DATE,
     IssueSortOptions.NEW,
-    IssueSortOptions.PRIORITY,
+    IssueSortOptions.TRENDS,
     IssueSortOptions.FREQ,
     IssueSortOptions.USER,
   ];

static/app/views/dashboards/widgetBuilder/issueWidget/utils.tsx

@@ -32,7 +32,7 @@ export const ISSUE_WIDGET_SORT_OPTIONS = [
   IssueSortOptions.DATE,
   IssueSortOptions.NEW,
   IssueSortOptions.FREQ,
-  IssueSortOptions.PRIORITY,
+  IssueSortOptions.TRENDS,
   IssueSortOptions.USER,
 ];
 

static/app/views/issueList/actions/sortOptions.tsx

@@ -19,7 +19,7 @@ function getSortTooltip(key: IssueSortOptions) {
       return t('When issue was flagged for review.');
     case IssueSortOptions.NEW:
       return t('First time the issue occurred.');
-    case IssueSortOptions.PRIORITY:
+    case IssueSortOptions.TRENDS:
       return t('Recent issues trending upward.');
     case IssueSortOptions.FREQ:
       return t('Number of events.');
@@ -37,7 +37,7 @@ function IssueListSortOptions({onSelect, sort, query}: Props) {
     ...(FOR_REVIEW_QUERIES.includes(query || '') ? [IssueSortOptions.INBOX] : []),
     IssueSortOptions.DATE,
     IssueSortOptions.NEW,
-    IssueSortOptions.PRIORITY,
+    IssueSortOptions.TRENDS,
     IssueSortOptions.FREQ,
     IssueSortOptions.USER,
   ];

static/app/views/issueList/overview.spec.tsx

@@ -329,7 +329,7 @@ describe('IssueList', function () {
             isPinned: false,
             isGlobal: true,
             query: 'assigned:me',
-            sort: 'priority',
+            sort: 'trends',
             type: 0,
           }),
         ],
@@ -349,7 +349,7 @@ describe('IssueList', function () {
             // Should be called with default query
             data:
               expect.stringContaining('assigned%3Ame') &&
-              expect.stringContaining('sort=priority'),
+              expect.stringContaining('sort=trends'),
           })
         );
       });
@@ -1403,7 +1403,7 @@ describe('IssueList', function () {
     expect(screen.getByText(textWithMarkupMatcher('26-50 of 500'))).toBeInTheDocument();
   });
 
-  describe('project low priority queue alert', function () {
+  describe('project low trends queue alert', function () {
     const {routerContext: newRouterContext} = initializeOrg();
 
     beforeEach(function () {

static/app/views/issueList/utils.tsx

@@ -177,7 +177,7 @@ export type QueryCounts = Partial<Record<Query, QueryCount>>;
 export enum IssueSortOptions {
   DATE = 'date',
   NEW = 'new',
-  PRIORITY = 'priority',
+  TRENDS = 'trends',
   FREQ = 'freq',
   USER = 'user',
   INBOX = 'inbox',
@@ -200,8 +200,8 @@ export function getSortLabel(key: string) {
   switch (key) {
     case IssueSortOptions.NEW:
       return t('First Seen');
-    case IssueSortOptions.PRIORITY:
-      return t('Priority');
+    case IssueSortOptions.TRENDS:
+      return t('Trends');
     case IssueSortOptions.FREQ:
       return t('Events');
     case IssueSortOptions.USER: