Browse Source

fix(starfish): use transaction method filter in span metrics and sample requests (#52365)

update remaining queries to use transaction method filter in span
metrics and sample requests
edwardgou-sentry 1 year ago
parent
commit
9cb6c27930

+ 1 - 1
static/app/views/starfish/queries/useSpanSamples.tsx

@@ -50,7 +50,7 @@ export const useSpanSamples = (options: Options) => {
 
   const {isLoading: isLoadingSeries, data: spanMetricsSeriesData} = useSpanMetricsSeries(
     groupId ? {group: groupId} : undefined,
-    {transactionName},
+    {transactionName, 'transaction.method': transactionMethod},
     [`p95(${SPAN_SELF_TIME})`],
     'sidebar-span-metrics'
   );

+ 3 - 1
static/app/views/starfish/views/spanSummaryPage/index.tsx

@@ -58,7 +58,9 @@ function SpanSummaryPage({params, location}: Props) {
   const {groupId} = params;
   const {transaction, transactionMethod, endpoint, endpointMethod} = location.query;
 
-  const queryFilter = endpoint ? {transactionName: endpoint} : undefined;
+  const queryFilter = endpoint
+    ? {transactionName: endpoint, 'transaction.method': transactionMethod}
+    : undefined;
   const sort =
     fromSorts(location.query[QueryParameterNames.SORT]).filter(isAValidSort)[0] ??
     DEFAULT_SORT; // We only allow one sort on this table in this view