Browse Source

add option to raise error if pluin fails to load (#15653)

Stephen Cefali 5 years ago
parent
commit
94f796a289
2 changed files with 4 additions and 2 deletions
  1. 1 1
      conftest.py
  2. 3 1
      src/sentry/runner/initializer.py

+ 1 - 1
conftest.py

@@ -36,7 +36,7 @@ def install_sentry_plugins():
 
     from sentry.runner.initializer import register_plugins
 
-    register_plugins(settings, test_plugins=True)
+    register_plugins(settings, test_plugins=True, raise_on_plugin_load_failure=True)
 
     settings.ASANA_CLIENT_ID = "abc"
     settings.ASANA_CLIENT_SECRET = "123"

+ 3 - 1
src/sentry/runner/initializer.py

@@ -11,7 +11,7 @@ from sentry.utils.sdk import configure_sdk
 from sentry.utils.warnings import DeprecatedSettingWarning
 
 
-def register_plugins(settings, test_plugins=False):
+def register_plugins(settings, test_plugins=False, raise_on_plugin_load_failure=False):
     from pkg_resources import iter_entry_points
     from sentry.plugins.base import plugins
 
@@ -35,6 +35,8 @@ def register_plugins(settings, test_plugins=False):
                 click.echo(
                     "Failed to load plugin %r:\n%s" % (ep.name, traceback.format_exc()), err=True
                 )
+                if raise_on_plugin_load_failure:
+                    raise
             else:
                 plugins.register(plugin)