Browse Source

build(travis): Fix eslint wrapper not returning proper codes (#8795)

`eslint-travis-wrapper` was always throwing a 0 status code regardless of lint errors 🙃
Billy Vong 6 years ago
parent
commit
94bef68e26

+ 1 - 1
bin/eslint-travis-wrapper

@@ -28,6 +28,6 @@ if (otherFormatterType) {
   const otherFormatter = cli.getFormatter(otherFormatterType);
 
   fs.writeFile('eslint.checkstyle.xml', otherFormatter(report.results), 'utf8', () => {
-    process.exit(0);
+    process.exit(report.errorCount);
   });
 }

+ 1 - 1
src/sentry/static/sentry/app/views/projectInstall/platform.jsx

@@ -111,7 +111,7 @@ const ProjectInstallPlatform = createReactClass({
 
   inInstallExperiment() {
     let {experimentPlatforms, integration} = this.state;
-    if (!integration || !integration.id) return;
+    if (!integration || !integration.id) return '';
 
     let currentPlatform = integration.id;
     let installExperiment =