Просмотр исходного кода

ref(codeowners): Do not create dummy issue owner record (#24682)

MeredithAnya 4 лет назад
Родитель
Сommit
92bce1c79f

+ 0 - 10
src/sentry/api/endpoints/project_codeowners.py

@@ -1,7 +1,5 @@
 import logging
 
-from django.utils import timezone
-
 from rest_framework import serializers, status
 from rest_framework.response import Response
 from rest_framework.exceptions import PermissionDenied
@@ -125,14 +123,6 @@ class ProjectCodeOwnerSerializer(CamelSnakeModelSerializer):
             raise serializers.ValidationError("This code mapping does not exist.")
 
     def create(self, validated_data):
-        # Create a project_ownership record with default values if none exists.
-        ownership = self.context["ownership"]
-        if ownership.id is None:
-            now = timezone.now()
-            ownership.date_created = now
-            ownership.last_updated = now
-            ownership.save()
-
         # Save projectcodeowners record
         repository_project_path_config = validated_data.pop("code_mapping_id", None)
         project = self.context["project"]

+ 1 - 8
tests/sentry/api/endpoints/test_project_codeowners.py

@@ -1,7 +1,7 @@
 from django.core.urlresolvers import reverse
 
 from sentry.testutils import APITestCase
-from sentry.models import Integration, ProjectCodeOwners, ProjectOwnership
+from sentry.models import Integration, ProjectCodeOwners
 
 
 class ProjectCodeOwnersEndpointTestCase(APITestCase):
@@ -169,13 +169,6 @@ class ProjectCodeOwnersEndpointTestCase(APITestCase):
         assert response.status_code == 400
         assert response.data == {"codeMappingId": ["This code mapping does not exist."]}
 
-    def test_default_project_ownership_record_created(self):
-        assert ProjectOwnership.objects.filter(project=self.project).exists() is False
-        with self.feature({"organizations:import-codeowners": True}):
-            response = self.client.post(self.url, self.data)
-        assert response.status_code == 201, response.content
-        assert ProjectOwnership.objects.filter(project=self.project).exists() is True
-
     def test_schema_is_correct(self):
         with self.feature({"organizations:import-codeowners": True}):
             response = self.client.post(self.url, self.data)