Browse Source

test(hybrid-cloud): Adds finally clause to test runner to reset celery settings correctly (#55426)

Gabe Villalobos 1 year ago
parent
commit
92175859f0
1 changed files with 5 additions and 3 deletions
  1. 5 3
      src/sentry/testutils/helpers/task_runner.py

+ 5 - 3
src/sentry/testutils/helpers/task_runner.py

@@ -12,9 +12,11 @@ def TaskRunner():
     prev = settings.CELERY_ALWAYS_EAGER
     settings.CELERY_ALWAYS_EAGER = True
     current_app.conf.CELERY_ALWAYS_EAGER = True
-    yield
-    current_app.conf.CELERY_ALWAYS_EAGER = prev
-    settings.CELERY_ALWAYS_EAGER = prev
+    try:
+        yield
+    finally:
+        current_app.conf.CELERY_ALWAYS_EAGER = prev
+        settings.CELERY_ALWAYS_EAGER = prev
 
 
 @contextmanager