Browse Source

fix(js): Correct eslint hook rule in Redirect (#34475)

Evan Purkhiser 2 years ago
parent
commit
9121039691
1 changed files with 7 additions and 4 deletions
  1. 7 4
      static/app/utils/redirect.tsx

+ 7 - 4
static/app/utils/redirect.tsx

@@ -8,18 +8,21 @@ type Props = {
   router?: InjectedRouter;
 };
 
-// This is react-router v4 <Redirect to="path/" /> component to allow things
-// to be declarative.
+/**
+ * Like react-router v4+'s <Redirect to="path/" />, this component allows
+ * redirects to be declarative.
+ */
 function Redirect({to, router}: Props) {
-  // Redirect on mount.
   const navigate = useNavigate();
+
+  // Redirect on mount.
   useEffect(() => {
     if (router) {
       router.replace(to);
     } else {
       navigate(to, {replace: true});
     }
-  }, []);
+  }, [navigate, router, to]);
 
   return null;
 }