Browse Source

feat(new-trace): Removing location query from being passed to traceview. (#70270)

We already pass all the query params we need as destructured props to
`getTraceDetailsUrl`, to load the trace view. Channeling the rest of the
`location.query` params leads to unwanted filtering in when naving out
of the traceview to ex: transaction summary.

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
Abdkhan14 10 months ago
parent
commit
90b3244fae

+ 0 - 1
static/app/components/events/interfaces/spans/utils.tsx

@@ -482,7 +482,6 @@ export function handleTraceDetailsRouting(
       organization,
       traceId,
       event.title,
-      location.query,
       getEventTimestamp(event),
       event.eventID
     );

+ 0 - 1
static/app/components/metrics/metricSamplesTable.tsx

@@ -669,7 +669,6 @@ function TraceId({
       end: selection.datetime.end,
       statsPeriod: selection.datetime.period,
     },
-    {},
     stringOrNumberTimestamp,
     eventId
   );

+ 0 - 1
static/app/components/profiling/profileEventsTable.tsx

@@ -175,7 +175,6 @@ function ProfileEventsCell<F extends FieldType>(props: ProfileEventsCellProps<F>
             props.baggage.organization,
             props.dataRow[key] ?? '',
             dataSelection,
-            {},
             timestamp
           )}
         >

+ 0 - 1
static/app/components/quickTrace/utils.tsx

@@ -146,7 +146,6 @@ export function generateTraceTarget(
       organization,
       traceId,
       dateSelection,
-      {},
       getEventTimestamp(event),
       event.eventID
     );

+ 0 - 1
static/app/utils/discover/urls.tsx

@@ -75,7 +75,6 @@ export function generateLinkToEventInTraceView({
       organization,
       String(traceSlug),
       dateSelection,
-      location.query,
       normalizedTimestamp,
       eventId,
       spanId

+ 0 - 1
static/app/views/dashboards/datasetConfig/errorsAndTransactions.tsx

@@ -428,7 +428,6 @@ function renderTraceAsLinkable(
     organization,
     String(data.trace),
     dateSelection,
-    {},
     getTimeStampFromTableDateField(data.timestamp),
     data.id || data.eventID
   );

+ 0 - 1
static/app/views/discover/table/tableView.tsx

@@ -385,7 +385,6 @@ function TableView(props: TableViewProps) {
           organization,
           String(dataRow.trace),
           dateSelection,
-          {},
           timestamp
         );
 

+ 0 - 1
static/app/views/performance/traceDetails/TraceDetailsRouting.tsx

@@ -36,7 +36,6 @@ function TraceDetailsRouting(props: Props) {
         organization,
         traceId,
         datetimeSelection,
-        location.query,
         getEventTimestamp(event),
         event.eventID
       );

+ 1 - 3
static/app/views/performance/traceDetails/utils.tsx

@@ -1,4 +1,4 @@
-import type {LocationDescriptorObject, Query} from 'history';
+import type {LocationDescriptorObject} from 'history';
 
 import {PAGE_URL_PARAM} from 'sentry/constants/pageFilters';
 import type {Organization, OrganizationSummary} from 'sentry/types';
@@ -19,7 +19,6 @@ export function getTraceDetailsUrl(
   organization: Pick<OrganizationSummary, 'slug' | 'features'>,
   traceSlug: string,
   dateSelection,
-  query: Query,
   timestamp?: string | number,
   eventId?: string,
   spanId?: string
@@ -27,7 +26,6 @@ export function getTraceDetailsUrl(
   const {start, end, statsPeriod} = dateSelection;
 
   const queryParams = {
-    ...query,
     statsPeriod,
     [PAGE_URL_PARAM.PAGE_START]: start,
     [PAGE_URL_PARAM.PAGE_END]: end,

+ 0 - 1
static/app/views/performance/traces/fieldRenderers.tsx

@@ -245,7 +245,6 @@ export function TraceIdRenderer({
       end: selection.datetime.end,
       statsPeriod: selection.datetime.period,
     },
-    {},
     stringOrNumberTimestamp,
     transactionId
   );

Some files were not shown because too many files changed in this diff