Browse Source

fix(feedback): Guard against falsy data returned from the server (#57060)

Ryan Albrecht 1 year ago
parent
commit
8d0410bae6

+ 1 - 1
static/app/components/feedback/hydrateFeedbackRecord.tsx

@@ -34,7 +34,7 @@ export default function hydrateFeedbackRecord(
 
   return {
     ...apiResponse,
-    feedback_id: apiResponse.feedback_id.replaceAll('-', ''),
+    feedback_id: apiResponse.feedback_id,
     timestamp: new Date(apiResponse.timestamp),
     tags,
   };

+ 1 - 1
static/app/components/feedback/useFetchFeedbackList.tsx

@@ -27,7 +27,7 @@ export default function useFetchFeedbackList(
   );
 
   return {
-    data: data?.map(hydrateFeedbackRecord),
+    data: data?.filter(Boolean).map(hydrateFeedbackRecord),
     isError,
     isLoading,
     pageLinks: getResponseHeader?.('Link') ?? undefined,