fix(ui): Add missing 'return' statement in <SourceMapsDebuggerModal /> (#70573)

static/app/components/events/interfaces/sourceMapsDebuggerModal.spec.tsx

@@ -0,0 +1,83 @@
+import {act, renderGlobalModal, screen} from 'sentry-test/reactTestingLibrary';
+
+import {openModal} from 'sentry/actionCreators/modal';
+
+import {
+  SourceMapsDebuggerModal,
+  type SourceMapsDebuggerModalProps,
+} from './sourceMapsDebuggerModal';
+
+const defaultAnalyticsParams = {
+  event_id: '12345',
+  project_id: '1',
+  organization: null,
+};
+
+const defaultSourceResolutionResults = {
+  debugIdProgress: 0,
+  debugIdProgressPercent: 0,
+  dist: null,
+  eventHasDebugIds: false,
+  frameIsResolved: false,
+  hasScrapingData: false,
+  matchingSourceFileNames: [],
+  matchingSourceMapName: null,
+  minDebugIdSdkVersion: null,
+  release: null,
+  releaseHasSomeArtifact: false,
+  releaseProgress: 0,
+  releaseProgressPercent: 0,
+  releaseSourceMapReference: null,
+  scrapingProgress: 0,
+  scrapingProgressPercent: 0,
+  sdkDebugIdSupport: 'full' as const,
+  sdkName: null,
+  sdkVersion: null,
+  sourceFileReleaseNameFetchingResult: 'found' as const,
+  sourceFileScrapingStatus: null,
+  sourceMapReleaseNameFetchingResult: 'found' as const,
+  sourceMapScrapingStatus: null,
+  stackFrameDebugId: null,
+  stackFramePath: null,
+  uploadedSomeArtifactWithDebugId: false,
+  uploadedSourceFileWithCorrectDebugId: false,
+  uploadedSourceMapWithCorrectDebugId: false,
+};
+
+const renderModal = (props?: Partial<SourceMapsDebuggerModalProps>) => {
+  renderGlobalModal();
+
+  act(() => {
+    openModal(
+      modalProps => (
+        <SourceMapsDebuggerModal
+          analyticsParams={defaultAnalyticsParams}
+          sourceResolutionResults={defaultSourceResolutionResults}
+          {...props}
+          {...modalProps}
+        />
+      ),
+      {
+        onClose: () => {},
+      }
+    );
+  });
+};
+
+describe('SourceMapsDebuggerModal', () => {
+  it(`renders proper message when active tab is 'release', release has some
+  artifact and release name fetching was unsuccessful`, () => {
+    const sourceResolutionResults = {
+      ...defaultSourceResolutionResults,
+      releaseProgressPercent: 100, // so the active tab is 'release'
+      releaseHasSomeArtifact: true,
+      sourceFileReleaseNameFetchingResult: 'unsuccessful' as const,
+    };
+
+    renderModal({sourceResolutionResults});
+
+    screen.getByText(
+      "This stack frame doesn't have a path. Check your SDK configuration to send a stack frame path!"
+    );
+  });
+});

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx

@@ -138,7 +138,7 @@ export interface FrameSourceMapDebuggerData {
   uploadedSourceMapWithCorrectDebugId: boolean;
 }
 
-interface SourceMapsDebuggerModalProps extends ModalRenderProps {
+export interface SourceMapsDebuggerModalProps extends ModalRenderProps {
   analyticsParams: SourceMapWizardBlueThunderAnalyticsParams & {
     organization: Organization | null;
   };
@@ -895,16 +895,18 @@ function ReleaseSourceFileMatchingChecklistItem({
   }
 
   if (sourceResolutionResults.stackFramePath === null) {
-    <CheckListItem status="alert" title={errorMessage}>
-      <CheckListInstruction type="muted">
-        <h6>{t('Stack Frame Without Path')}</h6>
-        <p>
-          {t(
-            "This stack frame doesn't have a path. Check your SDK configuration to send a stack frame path!"
-          )}
-        </p>
-      </CheckListInstruction>
-    </CheckListItem>;
+    return (
+      <CheckListItem status="alert" title={errorMessage}>
+        <CheckListInstruction type="muted">
+          <h6>{t('Stack Frame Without Path')}</h6>
+          <p>
+            {t(
+              "This stack frame doesn't have a path. Check your SDK configuration to send a stack frame path!"
+            )}
+          </p>
+        </CheckListInstruction>
+      </CheckListItem>
+    );
   }
 
   return (