Browse Source

nit(u2f): Add typing and fix component name (#72650)

Add `U2fInterface` typing to what we get back from the `Authenticator`
model, and also fix capitalization in component import
Seiji Chew 9 months ago
parent
commit
871b4c5be6

+ 1 - 1
src/sentry/api/endpoints/auth_index.py

@@ -73,7 +73,7 @@ class BaseAuthIndexEndpoint(Endpoint):
         # See if we have a u2f challenge/response
         if "challenge" in validator.validated_data and "response" in validator.validated_data:
             try:
-                interface = Authenticator.objects.get_interface(request.user, "u2f")
+                interface: U2fInterface = Authenticator.objects.get_interface(request.user, "u2f")
                 if not interface.is_enrolled():
                     raise LookupError()
                 challenge = json.loads(validator.validated_data["challenge"])

+ 2 - 1
src/sentry/web/frontend/sudo.py

@@ -4,6 +4,7 @@ from typing import Any
 
 from django.http.request import HttpRequest
 
+from sentry.auth.authenticators.u2f import U2fInterface
 from sentry.models.authenticator import Authenticator
 from sentry.utils import json
 from sentry.web.frontend.base import control_silo_view
@@ -19,7 +20,7 @@ class SudoView(BaseSudoView):
             return True
 
         try:
-            interface = Authenticator.objects.get_interface(request.user, "u2f")
+            interface: U2fInterface = Authenticator.objects.get_interface(request.user, "u2f")
             if not interface.is_enrolled():
                 raise LookupError()
         except LookupError:

+ 3 - 3
static/app/views/settings/account/accountSecurity/accountSecurityEnroll.tsx

@@ -25,7 +25,7 @@ import FormModel from 'sentry/components/forms/model';
 import type {FieldObject} from 'sentry/components/forms/types';
 import PanelItem from 'sentry/components/panels/panelItem';
 import TextCopyInput from 'sentry/components/textCopyInput';
-import U2fsign from 'sentry/components/u2f/u2fsign';
+import U2fSign from 'sentry/components/u2f/u2fsign';
 import {t} from 'sentry/locale';
 import OrganizationsStore from 'sentry/stores/organizationsStore';
 import {space} from 'sentry/styles/space';
@@ -52,7 +52,7 @@ type GetFieldsOpts = {
   /**
    * Callback when u2f device is activated
    */
-  onU2fTap: React.ComponentProps<typeof U2fsign>['onTap'];
+  onU2fTap: React.ComponentProps<typeof U2fSign>['onTap'];
   /**
    * Flag to track if we are currently sending the otp code
    */
@@ -128,7 +128,7 @@ const getFields = ({
     return [
       deviceNameField,
       () => (
-        <U2fsign
+        <U2fSign
           key="u2f-enroll"
           style={{marginBottom: 0}}
           challengeData={authenticator.challenge}