Browse Source

fix(feedback): fix feedback migration (#56218)

Michelle Zhang 1 year ago
parent
commit
85be12a2b1

+ 1 - 1
migrations_lockfile.txt

@@ -5,7 +5,7 @@ ahead of you.
 To resolve this, rebase against latest master and regenerate your migration. This file
 will then be regenerated, and you should be able to merge without conflicts.
 
-feedback: 0001_feedback
+feedback: 0002_feedback_add_org_id_and_rename_event_id
 nodestore: 0002_nodestore_no_dictfield
 replays: 0003_add_size_to_recording_segment
 sentry: 0551_drop_xactor_actor

+ 2 - 6
src/sentry/feedback/migrations/0001_feedback.py

@@ -1,4 +1,4 @@
-# Generated by Django 3.2.20 on 2023-09-12 23:52
+# Generated by Django 3.2.20 on 2023-09-07 18:06
 
 import django.utils.timezone
 from django.db import migrations, models
@@ -38,15 +38,11 @@ class Migration(CheckedMigration):
                     "project_id",
                     sentry.db.models.fields.bounded.BoundedBigIntegerField(db_index=True),
                 ),
-                ("replay_id", models.CharField(db_index=True, max_length=100, null=True)),
+                ("replay_id", models.CharField(db_index=True, max_length=32, null=True)),
                 ("url", models.CharField(max_length=1000, null=True)),
                 ("message", models.TextField()),
                 ("feedback_id", sentry.db.models.fields.uuid.UUIDField(max_length=32, unique=True)),
                 ("date_added", models.DateTimeField(default=django.utils.timezone.now)),
-                (
-                    "organization_id",
-                    sentry.db.models.fields.bounded.BoundedBigIntegerField(db_index=True),
-                ),
                 ("data", models.JSONField(null=True)),
             ],
             options={

+ 39 - 0
src/sentry/feedback/migrations/0002_feedback_add_org_id_and_rename_event_id.py

@@ -0,0 +1,39 @@
+# Generated by Django 3.2.20 on 2023-09-13 21:50
+
+from django.db import migrations, models
+
+import sentry.db.models.fields.bounded
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = False
+    checked = False
+
+    dependencies = [
+        ("feedback", "0001_feedback"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="feedback",
+            name="organization_id",
+            field=sentry.db.models.fields.bounded.BoundedBigIntegerField(db_index=True, default=1),
+            preserve_default=False,
+        ),
+        migrations.AlterField(
+            model_name="feedback",
+            name="replay_id",
+            field=models.CharField(db_index=True, max_length=100, null=True),
+        ),
+    ]

+ 1 - 1
src/sentry/feedback/models.py

@@ -27,4 +27,4 @@ class Feedback(Model):
         db_table = "feedback_feedback"
         index_together = [("project_id", "date_added")]
 
-    __repr__ = sane_repr("project_id", "event_id")
+    __repr__ = sane_repr("project_id", "feedback_id")