Browse Source

ref(ui) Replace icon-upgrade with SVG component (#19871)

Mark Story 4 years ago
parent
commit
8454822ee9

+ 2 - 1
src/sentry/static/sentry/app/components/events/sdkUpdates.jsx

@@ -5,6 +5,7 @@ import styled from '@emotion/styled';
 import SentryTypes from 'app/sentryTypes';
 import Alert from 'app/components/alert';
 import ExternalLink from 'app/components/links/externalLink';
+import {IconUpgrade} from 'app/icons';
 import {t, tct} from 'app/locale';
 import space from 'app/styles/space';
 import EventDataSection from 'app/components/events/eventDataSection';
@@ -121,7 +122,7 @@ class EventSdkUpdates extends React.Component {
         {data.map(suggestion => (
           <Alert
             type="info"
-            icon="icon-upgrade"
+            icon={<IconUpgrade />}
             key={getSuggestionComponentKey(suggestion)}
           >
             {t('We recommend you ')}

+ 2 - 2
src/sentry/static/sentry/app/views/settings/organizationDeveloperSettings/sentryApplicationRow/actionButtons.tsx

@@ -3,7 +3,7 @@ import styled from '@emotion/styled';
 
 import {LightWeightOrganization, SentryApp} from 'app/types';
 import Button from 'app/components/button';
-import {IconDelete, IconStats} from 'app/icons';
+import {IconDelete, IconStats, IconUpgrade} from 'app/icons';
 import ConfirmDelete from 'app/components/confirmDelete';
 import {t} from 'app/locale';
 import space from 'app/styles/space';
@@ -45,7 +45,7 @@ const ActionButtons = ({
     <StyledButton
       disabled={!!disablePublishReason}
       title={disablePublishReason}
-      icon="icon-upgrade"
+      icon={<IconUpgrade />}
       size="small"
       onClick={onPublish}
     >

+ 18 - 20
tests/js/spec/components/events/__snapshots__/sdkUpdates.spec.jsx.snap

@@ -47,14 +47,14 @@ exports[`EventSdkUpdates renders a suggestion to update the sdk and then enable
             className="css-16dhebx-SectionContents e1fbjd863"
           >
             <Alert
-              icon="icon-upgrade"
+              icon={<ForwardRef(IconUpgrade) />}
               iconSize="20px"
               key="{\\"enables\\":[{\\"enables\\":[],\\"type\\":\\"enableIntegration\\"}],\\"newSdkVersion\\":\\"0.9.0\\",\\"sdkName\\":\\"sentry.python\\",\\"sdkUrl\\":null,\\"type\\":\\"updateSdk\\"}"
               type="info"
             >
               <Component
                 className="css-17b0bb9-Alert ejthpj82"
-                icon="icon-upgrade"
+                icon={<ForwardRef(IconUpgrade) />}
                 iconSize="20px"
                 type="info"
               >
@@ -65,28 +65,26 @@ exports[`EventSdkUpdates renders a suggestion to update the sdk and then enable
                     <span
                       className="css-1vsw7fz-IconWrapper ejthpj80"
                     >
-                      <InlineSvg
-                        size="20px"
-                        src="icon-upgrade"
-                      >
-                        <ForwardRef
-                          className="css-tbsmsq-InlineSvg enyz4ql0"
-                          size="20px"
-                          src="icon-upgrade"
-                        >
+                      <IconUpgrade>
+                        <ForwardRef(SvgIcon)>
                           <svg
-                            className="css-tbsmsq-InlineSvg enyz4ql0"
-                            height="20px"
-                            viewBox={Object {}}
-                            width="20px"
+                            fill="currentColor"
+                            height="16px"
+                            viewBox="0 0 16 16"
+                            width="16px"
                           >
-                            <use
-                              href="#test"
-                              xlinkHref="#test"
+                            <path
+                              d="M11.54,7.5A.79.79,0,0,1,11,7.28l-3-3-3,3a.75.75,0,0,1-1.06,0,.74.74,0,0,1,0-1.06L7.47,2.67a.77.77,0,0,1,1.06,0l3.54,3.55a.74.74,0,0,1,0,1.06A.77.77,0,0,1,11.54,7.5Z"
+                            />
+                            <path
+                              d="M8,12.8a.76.76,0,0,1-.75-.75V3.2a.75.75,0,1,1,1.5,0v8.85A.76.76,0,0,1,8,12.8Z"
+                            />
+                            <path
+                              d="M13.25,16H2.75A2.75,2.75,0,0,1,0,13.25V2.75A2.75,2.75,0,0,1,2.75,0h10.5A2.75,2.75,0,0,1,16,2.75v10.5A2.75,2.75,0,0,1,13.25,16ZM2.75,1.5A1.25,1.25,0,0,0,1.5,2.75v10.5A1.25,1.25,0,0,0,2.75,14.5h10.5a1.25,1.25,0,0,0,1.25-1.25V2.75A1.25,1.25,0,0,0,13.25,1.5Z"
                             />
                           </svg>
-                        </ForwardRef>
-                      </InlineSvg>
+                        </ForwardRef(SvgIcon)>
+                      </IconUpgrade>
                     </span>
                   </IconWrapper>
                   <StyledTextBlock>