fix(bug reports): check for null environment (#57038)

src/sentry/feedback/serializers.py

@@ -29,6 +29,11 @@ class FeedbackResponseType(TypedDict):
 @register(Feedback)
 class FeedbackSerializer(Serializer):
     def serialize(self, obj, attrs, user, **kwargs) -> FeedbackResponseType:
+        if obj.environment:
+            env = obj.environment.name
+        else:
+            env = "production"
+
         res: FeedbackResponseType = {
             "browser": obj.data.get("browser") or {},
             "locale": obj.data.get("locale") or {},
@@ -40,7 +45,7 @@ class FeedbackSerializer(Serializer):
             "dist": obj.data.get("dist"),
             "sdk": obj.data.get("sdk"),
             "contact_email": obj.data.get("feedback").get("contact_email"),
-            "environment": obj.environment.name,
+            "environment": env,
             "feedback_id": obj.feedback_id,
             "message": obj.message,
             "platform": obj.data.get("platform"),

tests/sentry/feedback/test_project_feedback_details.py

@@ -231,3 +231,51 @@ class ProjectFeedbackDetailTest(APITestCase):
             )
             response = self.client.get(path)
             assert response.status_code == 404
+
+    def test_null_env(self):
+        with self.feature({"organizations:user-feedback-ingest": True}):
+            # Feedback with null environment
+            Feedback.objects.create(
+                data={
+                    "feedback": {
+                        "contact_email": "colton.allen@sentry.io",
+                        "message": "I really like this user-feedback feature!",
+                        "replay_id": "ec3b4dc8b79f417596f7a1aa4fcca5d2",
+                        "url": "https://docs.sentry.io/platforms/javascript/",
+                    },
+                    "platform": "javascript",
+                    "release": "version@1.3",
+                    "sdk": {"name": "sentry.javascript.react", "version": "6.18.1"},
+                    "tags": {"key": "value"},
+                    "user": {
+                        "email": "username@example.com",
+                        "id": "123",
+                        "ip_address": "127.0.0.1",
+                        "name": "user",
+                        "username": "user2270129",
+                    },
+                    "dist": "abc123",
+                    "contexts": {},
+                },
+                date_added=datetime.datetime.fromtimestamp(1234456),
+                feedback_id=self.feedback_id_1,
+                url="https://docs.sentry.io/platforms/javascript/",
+                message="I really like this user-feedback feature!",
+                replay_id=self.replay_id_1,
+                project_id=self.project.id,
+                organization_id=self.organization.id,
+                environment=None,
+            )
+            path = reverse(
+                self.endpoint,
+                args=[
+                    self.organization.slug,
+                    self.project.slug,
+                    self.feedback_id_1,
+                ],
+            )
+            response = self.client.get(path)
+            # Should return successfully with environment set to `production`
+            assert response.status_code == 200
+            feedback = response.data
+            assert feedback["environment"] == "production"