|
@@ -193,13 +193,6 @@ jobs:
|
|
|
base-path: .artifacts/visual-snapshots/jest
|
|
|
css-path: src/sentry/static/sentry/dist/entrypoints/sentry.css
|
|
|
|
|
|
- - name: Save snapshots
|
|
|
- uses: getsentry/action-visual-snapshot@ea663f1be8b73c86b18081d714423ce52352e934
|
|
|
- with:
|
|
|
- artifact-name: frontend-snapshots
|
|
|
- save-only: true
|
|
|
- snapshot-path: .artifacts/visual-snapshots
|
|
|
-
|
|
|
# We only upload coverage data for FE changes since it conflicts with
|
|
|
# codecov's carry forward functionality.
|
|
|
# Upload coverage data even if running the tests step fails since
|
|
@@ -211,23 +204,6 @@ jobs:
|
|
|
files: .artifacts/coverage/*
|
|
|
type: frontend
|
|
|
|
|
|
- frontend-visual-diff:
|
|
|
- needs: [frontend-browser-tests]
|
|
|
- name: Visual diff
|
|
|
- runs-on: ubuntu-20.04
|
|
|
- timeout-minutes: 20
|
|
|
- if: github.event.pull_request.head.repo.full_name == 'getsentry/sentry'
|
|
|
- steps:
|
|
|
- - name: Diff snapshots
|
|
|
- uses: getsentry/action-visual-snapshot@ea663f1be8b73c86b18081d714423ce52352e934
|
|
|
- with:
|
|
|
- action-name: 'Visual Snapshot: Frontend'
|
|
|
- artifact-name: 'frontend-snapshots'
|
|
|
- base-branch: 'master'
|
|
|
- api-token: ${{ secrets.VISUAL_SNAPSHOT_SECRET }}
|
|
|
- gcs-bucket: 'sentry-visual-snapshots'
|
|
|
- gcp-service-account-key: ${{ secrets.SNAPSHOT_GOOGLE_SERVICE_ACCOUNT_KEY }}
|
|
|
-
|
|
|
# This check runs once all dependant jobs have passed
|
|
|
# It symbolizes that all required Frontend checks have succesfully passed (Or skipped)
|
|
|
# This check is the only required Github check
|