Просмотр исходного кода

chore(widget-lib): Add number of widgets selected to CTA (#31574)

Show the number of prebuilt widgets selected
in the Add CTA. Also update some prebuilt query.
Shruthi 3 лет назад
Родитель
Сommit
814c41e405

+ 4 - 4
static/app/components/modals/dashboardWidgetLibraryModal/index.tsx

@@ -6,7 +6,6 @@ import styled from '@emotion/styled';
 import {ModalRenderProps} from 'sentry/actionCreators/modal';
 import Tooltip from 'sentry/components/tooltip';
 import {t, tct} from 'sentry/locale';
-import space from 'sentry/styles/space';
 import {Organization} from 'sentry/types';
 import trackAdvancedAnalyticsEvent from 'sentry/utils/analytics/trackAdvancedAnalyticsEvent';
 import {assignTempId} from 'sentry/views/dashboardsV2/layoutUtils';
@@ -118,7 +117,9 @@ function DashboardWidgetLibraryModal({
                 handleSubmit();
               }}
             >
-              {t('Add')}
+              {selectedWidgets.length
+                ? tct('Add ([numWidgets])', {numWidgets: selectedWidgets.length})
+                : t('Add')}
             </StyledButton>
           </Tooltip>
         </ButtonBar>
@@ -134,8 +135,7 @@ export const modalCss = css`
 `;
 
 const StyledButton = styled(Button)`
-  padding-left: ${space(3)};
-  padding-right: ${space(3)};
+  min-width: 90px;
 `;
 
 export default DashboardWidgetLibraryModal;

+ 3 - 3
static/app/views/dashboardsV2/widgetLibrary/data.tsx

@@ -17,7 +17,7 @@ export const DEFAULT_WIDGETS: Readonly<Array<WidgetTemplate>> = [
     queries: [
       {
         name: '',
-        conditions: '!event.type:error',
+        conditions: 'event.type:transaction',
         fields: [
           'p50(transaction.duration)',
           'p75(transaction.duration)',
@@ -37,7 +37,7 @@ export const DEFAULT_WIDGETS: Readonly<Array<WidgetTemplate>> = [
     queries: [
       {
         name: '',
-        conditions: '!event.type:error',
+        conditions: 'event.type:transaction',
         fields: ['transaction', 'count()'],
         orderby: '-count',
       },
@@ -85,7 +85,7 @@ export const DEFAULT_WIDGETS: Readonly<Array<WidgetTemplate>> = [
     queries: [
       {
         name: '',
-        conditions: '!event.type:error',
+        conditions: 'event.type:transaction',
         fields: [
           'equation|(count_if(transaction.duration,greater,300) / count()) * 100',
           'equation|(count_if(transaction.duration,lessOrEquals,300) / count()) * 100',

+ 1 - 1
tests/js/spec/components/modals/dashboardWidgetLibraryModal.spec.jsx

@@ -119,7 +119,7 @@ describe('Modals -> DashboardWidgetLibraryModal', function () {
         description: 'Top 5 transactions with the largest volume.',
         queries: [
           {
-            conditions: '!event.type:error',
+            conditions: 'event.type:transaction',
             fields: ['transaction', 'count()'],
             name: '',
             orderby: '-count',