Просмотр исходного кода

fix(ci): Acceptance collector job should not be skipped if there are FE changes (#34486)

This is a fallout from #34004.

This got noticed in [this run](https://github.com/getsentry/sentry/runs/6379373504?check_suite_focus=true) were an FE check failed yet the collector job got skipped instead.
Armen Zambrano G 2 лет назад
Родитель
Сommit
8067aeb3c5
2 измененных файлов с 3 добавлено и 2 удалено
  1. 1 0
      .github/file-filters.yml
  2. 2 2
      .github/workflows/acceptance.yml

+ 1 - 0
.github/file-filters.yml

@@ -56,6 +56,7 @@ backend: &backend
   - 'migrations_lockfile.txt'
   - 'config/**/*'
 
+# This is the ultimate controller for acceptance.yml
 acceptance: &acceptance
   - *backend
   - *frontend

+ 2 - 2
.github/workflows/acceptance.yml

@@ -309,7 +309,7 @@ jobs:
         if: needs.files-changed.outputs.backend == 'true'
 
   visual-diff:
-    if: needs.files-changed.outputs.backend_any_type == 'true'
+    if: needs.files-changed.outputs.acceptance == 'true'
     # This guarantees that we will only schedule Visual Snapshots if all
     # workflows that generate artifacts succeed
     needs: [acceptance, frontend, chartcuterie]
@@ -337,7 +337,7 @@ jobs:
   fake-visual-snapshot:
     name: Visual Snapshot
     # Opposite condition to "triggers visual snapshot" required check
-    if: needs.files-changed.outputs.backend_any_type != 'true'
+    if: needs.files-changed.outputs.acceptance != 'true'
     runs-on: ubuntu-20.04
     steps:
       - name: Sentaur attack