Browse Source

fix(hybridcloud) Remove externalactor.actor_id (#60548)

This field was removed from django state a few months back in #56534
This field is now causing issues in deletions as foreign key constraints
are preventing records from being deleted. Removing the unused column
seems like the most efficient solution.

Fixes SENTRY-163E
Mark Story 1 year ago
parent
commit
7ed14be9ef
2 changed files with 41 additions and 1 deletions
  1. 1 1
      migrations_lockfile.txt
  2. 40 0
      src/sentry/migrations/0607_drop_externalactor_actorid.py

+ 1 - 1
migrations_lockfile.txt

@@ -9,5 +9,5 @@ feedback: 0003_feedback_add_env
 hybridcloud: 0009_make_user_id_optional_for_slug_reservation_replica
 nodestore: 0002_nodestore_no_dictfield
 replays: 0003_add_size_to_recording_segment
-sentry: 0606_update_user_to_optional_organization_slug_reservation
+sentry: 0607_drop_externalactor_actorid
 social_auth: 0002_default_auto_field

+ 40 - 0
src/sentry/migrations/0607_drop_externalactor_actorid.py

@@ -0,0 +1,40 @@
+# Generated by Django 3.2.23 on 2023-11-24 16:00
+
+from django.db import migrations
+
+from sentry.new_migrations.migrations import CheckedMigration
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production. For
+    # the most part, this should only be used for operations where it's safe to run the migration
+    # after your code has deployed. So this should not be used for most operations that alter the
+    # schema of a table.
+    # Here are some things that make sense to mark as dangerous:
+    # - Large data migrations. Typically we want these to be run manually by ops so that they can
+    #   be monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   have ops run this and not block the deploy. Note that while adding an index is a schema
+    #   change, it's completely safe to run the operation after the code has deployed.
+    is_dangerous = False
+
+    dependencies = [
+        ("sentry", "0606_update_user_to_optional_organization_slug_reservation"),
+    ]
+
+    operations = [
+        migrations.SeparateDatabaseAndState(
+            state_operations=[],
+            database_operations=[
+                migrations.RunSQL(
+                    sql="""
+                    ALTER TABLE "sentry_externalactor" DROP COLUMN actor_id;
+                    """,
+                    reverse_sql="""
+                    ALTER TABLE "sentry_externalactor" ADD COLUMN actor_id BIGINT NULL;
+                    """,
+                    hints={"tables": ["sentry_externalactor"]},
+                )
+            ],
+        )
+    ]