chore(actor) Backfill rule.owner fields (#69510)

As part of the work to remove `Actor` we need to populate
`owner_user_id` and `owner_team_id` on `Rule`.

New writes were addressed with #69427

migrations_lockfile.txt

@@ -9,5 +9,5 @@ feedback: 0004_index_together
 hybridcloud: 0016_add_control_cacheversion
 nodestore: 0002_nodestore_no_dictfield
 replays: 0004_index_together
-sentry: 0703_add_team_user_to_rule
+sentry: 0704_backfill_rule_user_team
 social_auth: 0002_default_auto_field

src/sentry/migrations/0704_backfill_rule_user_team.py

@@ -0,0 +1,60 @@
+# Generated by Django 5.0.3 on 2024-04-23 14:55
+import logging
+
+from django.apps.registry import Apps
+from django.db import migrations
+from django.db.backends.base.schema import BaseDatabaseSchemaEditor
+from django.db.models import Q
+
+from sentry.new_migrations.migrations import CheckedMigration
+from sentry.utils.query import RangeQuerySetWrapperWithProgressBar
+
+
+def backfill_rule_owners(apps: Apps, schema_editor: BaseDatabaseSchemaEditor) -> None:
+    Rule = apps.get_model("sentry", "Rule")
+    Actor = apps.get_model("sentry", "Actor")
+
+    expr = Q(owner_user_id__isnull=True) | Q(owner_team_id__isnull=True)
+
+    rules = Rule.objects.filter(owner_id__isnull=False).filter(expr)
+    for rule in RangeQuerySetWrapperWithProgressBar(rules):
+        actor = Actor.objects.get(id=rule.owner_id)
+        changed = False
+        if actor.user_id:
+            rule.owner_user_id = actor.user_id
+            changed = True
+        elif actor.team_id:
+            rule.owner_team_id = actor.team_id
+            changed = True
+        else:
+            logging.info("Actor %s is neither a user or team", actor.id)
+        if changed:
+            rule.save(update_fields=["owner_team_id", "owner_user_id"])
+
+
+class Migration(CheckedMigration):
+    # This flag is used to mark that a migration shouldn't be automatically run in production.
+    # This should only be used for operations where it's safe to run the migration after your
+    # code has deployed. So this should not be used for most operations that alter the schema
+    # of a table.
+    # Here are some things that make sense to mark as post deployment:
+    # - Large data migrations. Typically we want these to be run manually so that they can be
+    #   monitored and not block the deploy for a long period of time while they run.
+    # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
+    #   run this outside deployments so that we don't block them. Note that while adding an index
+    #   is a schema change, it's completely safe to run the operation after the code has deployed.
+    # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment
+
+    is_post_deployment = True
+
+    dependencies = [
+        ("sentry", "0703_add_team_user_to_rule"),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            backfill_rule_owners,
+            reverse_code=migrations.RunPython.noop,
+            hints={"tables": ["sentry_rule", "sentry_actor"]},
+        )
+    ]

tests/sentry/migrations/test_704_backfill_rule_user_team.py

@@ -0,0 +1,56 @@
+from sentry.models.actor import ACTOR_TYPES, Actor
+from sentry.models.rule import Rule
+from sentry.testutils.cases import TestMigrations
+
+
+class BackfillRuleUserTeamTest(TestMigrations):
+    migrate_from = "0703_add_team_user_to_rule"
+    migrate_to = "0704_backfill_rule_user_team"
+
+    def setup_initial_state(self):
+        self.org = self.create_organization(owner=self.user)
+        self.team = self.create_team(organization=self.org, members=[self.user])
+        self.project = self.create_project(organization=self.org)
+
+        self.user_actor = Actor.objects.create(type=ACTOR_TYPES["user"], user_id=self.user.id)
+        self.team_actor = Actor.objects.get(type=ACTOR_TYPES["team"], team_id=self.team.id)
+        self.team_rule = Rule.objects.create(
+            project=self.project,
+            label="team rule",
+            owner=self.team_actor,
+            owner_team=self.team,
+        )
+        self.user_rule = Rule.objects.create(
+            project=self.project,
+            label="user rule",
+            owner=self.user_actor,
+            owner_user_id=self.user.id,
+        )
+
+        other_user = self.create_user()
+        other_actor = Actor.objects.create(type=ACTOR_TYPES["user"], user_id=other_user.id)
+        self.valid = Rule.objects.create(
+            project=self.project,
+            label="valid",
+            owner=other_actor,
+            owner_user_id=other_user.id,
+        )
+
+        # Use QuerySet.update() to avoid validation in AlertRule
+        Rule.objects.filter(id__in=[self.team_rule.id, self.user_rule.id]).update(
+            owner_team_id=None, owner_user_id=None
+        )
+
+    def test(self):
+        self.user_rule.refresh_from_db()
+        self.team_rule.refresh_from_db()
+        self.valid.refresh_from_db()
+
+        assert self.user_rule.owner_user_id == self.user.id
+        assert self.user_rule.owner_team_id is None
+
+        assert self.team_rule.owner_team_id == self.team.id
+        assert self.team_rule.owner_user_id is None
+
+        assert self.valid.owner_team_id is None
+        assert self.valid.owner_user_id