Browse Source

fix(onboarding): Add onboarding sandbox btn cta & logExperiment (#32759)

* fix(onboarding): Add  onboarding sandbox btn cta

* Turn on experiment assignment
Zhixing Zhang 3 years ago
parent
commit
7be23836ed

+ 2 - 4
static/app/views/onboarding/onboardingController.tsx

@@ -1,5 +1,6 @@
-import {ComponentPropsWithoutRef} from 'react';
+import {ComponentPropsWithoutRef, useEffect} from 'react';
 
+import {logExperiment} from 'sentry/utils/analytics';
 import withExperiment from 'sentry/utils/withExperiment';
 import withOrganization from 'sentry/utils/withOrganization';
 
@@ -12,15 +13,12 @@ type Props = Omit<ComponentPropsWithoutRef<typeof Onboarding>, 'projects'> & {
 };
 
 function OnboardingController({experimentAssignment, ...rest}: Props) {
-  /*
-  TODO: enable logExperiment after testing & launch
   useEffect(() => {
     logExperiment({
       key: 'TargetedOnboardingWelcomePageExperiment',
       organization: rest.organization,
     });
   }, []);
-  */
   if (rest.params.step === 'welcome' && experimentAssignment) {
     return <TargetedOnboarding />;
   }

+ 12 - 0
static/app/views/onboarding/targetedOnboarding/welcome.tsx

@@ -141,6 +141,18 @@ function TargetedOnboardingWelcome({organization}: Props) {
                   <SandboxBtnWithFill
                     scenario="oneIssue"
                     priority="primary"
+                    clientData={{
+                      cta: {
+                        id: 'onboarding',
+                        shortTitle: t('Continue'),
+                        title: t('Continue Onboarding'),
+                        url: new URL(
+                          `/onboarding/${organization.slug}/welcome/`,
+                          window.location.origin
+                        ).toString(),
+                      },
+                      skipEmail: true,
+                    }}
                     {...{source}}
                   >
                     {t('Explore')}