Browse Source

feat(uptime): Use project_subscription env for issues (#78340)

Evan Purkhiser 5 months ago
parent
commit
799e7ca0dc
2 changed files with 8 additions and 3 deletions
  1. 6 1
      src/sentry/uptime/issue_platform.py
  2. 2 2
      tests/sentry/uptime/test_issue_platform.py

+ 6 - 1
src/sentry/uptime/issue_platform.py

@@ -89,8 +89,13 @@ def build_event_data_for_occurrence(
     project_subscription: ProjectUptimeSubscription,
     occurrence: IssueOccurrence,
 ):
+    # Default environment when it hasn't been configured
+    env = "prod"
+    if project_subscription.environment:
+        env = project_subscription.environment.name
+
     return {
-        "environment": "prod",  # TODO: Include the environment here when we have it
+        "environment": env,
         "event_id": occurrence.event_id,
         "fingerprint": occurrence.fingerprint,
         "platform": "other",

+ 2 - 2
tests/sentry/uptime/test_issue_platform.py

@@ -94,10 +94,10 @@ class BuildEventDataForOccurrenceTest(UptimeTestCase):
             level="error",
             culprit="",
         )
-        project_subscription = self.create_project_uptime_subscription()
+        project_subscription = self.create_project_uptime_subscription(env=self.environment)
         event_data = build_event_data_for_occurrence(result, project_subscription, occurrence)
         assert event_data == {
-            "environment": "prod",
+            "environment": "development",
             "event_id": event_id.hex,
             "fingerprint": fingerprint,
             "platform": "other",