Browse Source

onboarding ux fixes (#5771)

* small ux improvements

* fix string

* percy race condition

* wait for more loading
Max Bittker 7 years ago
parent
commit
79320ddea6

+ 1 - 1
src/sentry/static/sentry/app/views/onboarding/index.jsx

@@ -74,7 +74,7 @@ const OnboardingWizard = React.createClass({
         browserHistory.push(url);
       },
       error: err => {
-        Raven.captureMessage('oboarding project creation failed', {
+        Raven.captureMessage('Onboarding project creation failed', {
           extra: err
         });
 

+ 4 - 0
src/sentry/static/sentry/app/views/onboarding/onboarding.less

@@ -1,7 +1,11 @@
 @onboarding-sidebar-width: 300px;
 
 .onboarding-container {
+
   margin-left: @onboarding-sidebar-width - @sidebar-width;
+
+  max-width: 800px + @onboarding-sidebar-width;
+
   @media(max-width: @screen-sm-max) {
       margin-left: 0;
   }

+ 2 - 2
src/sentry/static/sentry/app/views/onboarding/project/index.jsx

@@ -34,9 +34,9 @@ const Project = React.createClass({
               onChange={e => this.props.setName(e.target.value)}
             />
           </div>
-          <div className="btn btn-primary pull-right" onClick={this.submit}>
+          <button className="btn btn-primary pull-right" onClick={this.submit}>
             {t('Continue')}
-          </div>
+          </button>
         </div>
       </div>
     );

+ 1 - 0
tests/acceptance/test_create_team.py

@@ -15,4 +15,5 @@ class CreateTeamTest(AcceptanceTestCase):
 
     def test_simple(self):
         self.browser.get('/organizations/{}/teams/new/'.format(self.org.slug))
+        self.browser.wait_until_not('.loading')
         self.browser.snapshot(name='create team')

+ 2 - 0
tests/acceptance/test_organization_onboarding.py

@@ -15,4 +15,6 @@ class CreateOrganizationTest(AcceptanceTestCase):
 
     def test_simple(self):
         self.browser.get('/onboarding/%s/' % self.org.slug)
+        self.browser.wait_until_not('.loading')
+        self.browser.wait_until('.step-container')
         self.browser.snapshot(name='organization onboarding')

+ 2 - 2
tests/js/spec/views/onboarding/project/__snapshots__/index.spec.jsx.snap

@@ -38,12 +38,12 @@ exports[`Project render() should render NotFound if no matching organization 1`]
         type="text"
       />
     </div>
-    <div
+    <button
       className="btn btn-primary pull-right"
       onClick={[Function]}
     >
       Continue
-    </div>
+    </button>
   </div>
 </div>
 `;