Browse Source

ref(project-config): Remove metrics and sampling rate overrides (#36180)

Iker Barriocanal 2 years ago
parent
commit
78fea8be75

+ 2 - 11
src/sentry/api/endpoints/relay/project_configs.py

@@ -86,19 +86,12 @@ class RelayProjectConfigsEndpoint(Endpoint):
             # considering them v3.
             use_v3 = False
             reason = "fullConfig"
-            version = "2"  # Downgrade to 2 for reporting metrics
         elif no_cache:
             use_v3 = False
             reason = "noCache"
-            version = "2"  # Downgrade to 2 for reporting metrics
 
         set_tag("relay_use_v3", use_v3)
         set_tag("relay_use_v3_rejected", reason)
-        metrics.incr(
-            "api.endpoints.relay.project_configs.post",
-            tags={"version": version, "reason": reason},
-            sample_rate=1,
-        )
 
         return use_v3
 
@@ -114,10 +107,8 @@ class RelayProjectConfigsEndpoint(Endpoint):
             else:
                 proj_configs[key] = computed
 
-        metrics.incr("relay.project_configs.post_v3.pending", amount=len(pending), sample_rate=1)
-        metrics.incr(
-            "relay.project_configs.post_v3.fetched", amount=len(proj_configs), sample_rate=1
-        )
+        metrics.incr("relay.project_configs.post_v3.pending", amount=len(pending))
+        metrics.incr("relay.project_configs.post_v3.fetched", amount=len(proj_configs))
         res = {"configs": proj_configs, "pending": pending}
 
         return Response(res, status=200)

+ 2 - 2
src/sentry/relay/projectconfig_debounce_cache/redis.py

@@ -44,11 +44,11 @@ class RedisProjectConfigDebounceCache(ProjectConfigDebounceCache):
         key = self._get_redis_key(public_key, project_id, organization_id)
         client = self._get_redis_client(key)
         client.setex(key, REDIS_CACHE_TIMEOUT, 1)
-        metrics.incr("relay.projectconfig_debounce_cache.debounce", sample_rate=1)
+        metrics.incr("relay.projectconfig_debounce_cache.debounce")
 
     def mark_task_done(self, *, public_key, project_id, organization_id):
         key = self._get_redis_key(public_key, project_id, organization_id)
         client = self._get_redis_client(key)
         ret = client.delete(key)
-        metrics.incr("relay.projectconfig_debounce_cache.task_done", sample_rate=1)
+        metrics.incr("relay.projectconfig_debounce_cache.task_done")
         return ret