Browse Source

ref(js): Remove DebugMetaActions (#38395)

Evan Purkhiser 2 years ago
parent
commit
77706a4f50

+ 2 - 2
static/app/components/events/interfaces/debugMeta/index.tsx

@@ -18,7 +18,7 @@ import {getImageRange, parseAddress} from 'sentry/components/events/interfaces/u
 import {PanelTable} from 'sentry/components/panels';
 import QuestionTooltip from 'sentry/components/questionTooltip';
 import {t} from 'sentry/locale';
-import DebugMetaStore, {DebugMetaActions} from 'sentry/stores/debugMetaStore';
+import DebugMetaStore from 'sentry/stores/debugMetaStore';
 import space from 'sentry/styles/space';
 import {Group, Organization, Project} from 'sentry/types';
 import {Image, ImageStatus} from 'sentry/types/debugImage';
@@ -374,7 +374,7 @@ class DebugMetaWithRouter extends PureComponent<Props, State> {
   };
 
   handleChangeSearchTerm = (searchTerm = '') => {
-    DebugMetaActions.updateFilter(searchTerm);
+    DebugMetaStore.updateFilter(searchTerm);
   };
 
   handleResetFilter = () => {

+ 2 - 2
static/app/components/events/interfaces/frame/line.tsx

@@ -8,7 +8,7 @@ import {STACKTRACE_PREVIEW_TOOLTIP_DELAY} from 'sentry/components/stacktracePrev
 import StrictClick from 'sentry/components/strictClick';
 import {IconChevron, IconRefresh} from 'sentry/icons';
 import {t} from 'sentry/locale';
-import {DebugMetaActions} from 'sentry/stores/debugMetaStore';
+import DebugMetaStore from 'sentry/stores/debugMetaStore';
 import space from 'sentry/styles/space';
 import {Frame, Organization, PlatformType, SentryAppComponent} from 'sentry/types';
 import {Event} from 'sentry/types/event';
@@ -163,7 +163,7 @@ export class Line extends Component<Props, State> {
 
     const {instructionAddr, addrMode} = this.props.data;
     if (instructionAddr) {
-      DebugMetaActions.updateFilter(
+      DebugMetaStore.updateFilter(
         makeFilter(instructionAddr, addrMode, this.props.image)
       );
     }

+ 2 - 2
static/app/components/events/interfaces/frame/lineV2/native.tsx

@@ -2,7 +2,7 @@ import styled from '@emotion/styled';
 import scrollToElement from 'scroll-to-element';
 
 import {t} from 'sentry/locale';
-import {DebugMetaActions} from 'sentry/stores/debugMetaStore';
+import DebugMetaStore from 'sentry/stores/debugMetaStore';
 import space from 'sentry/styles/space';
 import {Frame} from 'sentry/types';
 
@@ -89,7 +89,7 @@ function Native({
     event.stopPropagation(); // to prevent collapsing if collapsible
 
     if (instructionAddr) {
-      DebugMetaActions.updateFilter(makeFilter(instructionAddr));
+      DebugMetaStore.updateFilter(makeFilter(instructionAddr));
     }
     scrollToElement('#images-loaded');
   }

+ 2 - 2
static/app/components/events/interfaces/frame/lineV2/nativeV2.tsx

@@ -4,7 +4,7 @@ import scrollToElement from 'scroll-to-element';
 
 import {TraceEventDataSectionContext} from 'sentry/components/events/traceEventDataSection';
 import {t} from 'sentry/locale';
-import {DebugMetaActions} from 'sentry/stores/debugMetaStore';
+import DebugMetaStore from 'sentry/stores/debugMetaStore';
 import space from 'sentry/styles/space';
 import {Frame} from 'sentry/types';
 
@@ -89,7 +89,7 @@ function Native({
     event.stopPropagation(); // to prevent collapsing if collapsible
 
     if (instructionAddr) {
-      DebugMetaActions.updateFilter(makeFilter(instructionAddr));
+      DebugMetaStore.updateFilter(makeFilter(instructionAddr));
     }
     scrollToElement('#images-loaded');
   }

+ 2 - 2
static/app/components/events/interfaces/nativeFrame.tsx

@@ -24,7 +24,7 @@ import {IconInfo} from 'sentry/icons/iconInfo';
 import {IconQuestion} from 'sentry/icons/iconQuestion';
 import {IconWarning} from 'sentry/icons/iconWarning';
 import {t} from 'sentry/locale';
-import {DebugMetaActions} from 'sentry/stores/debugMetaStore';
+import DebugMetaStore from 'sentry/stores/debugMetaStore';
 import space from 'sentry/styles/space';
 import {Frame, PlatformType, SentryAppComponent} from 'sentry/types';
 import {Event} from 'sentry/types/event';
@@ -198,7 +198,7 @@ function NativeFrame({
           ? `${image.debug_id}!${frame.instructionAddr}`
           : frame.instructionAddr;
 
-      DebugMetaActions.updateFilter(searchTerm);
+      DebugMetaStore.updateFilter(searchTerm);
     }
 
     scrollToElement('#images-loaded');

+ 4 - 16
static/app/stores/debugMetaStore.tsx

@@ -1,8 +1,4 @@
-import {createActions, createStore, StoreDefinition} from 'reflux';
-
-import {makeSafeRefluxStore, SafeStoreDefinition} from 'sentry/utils/makeSafeRefluxStore';
-
-const DebugMetaActions = createActions(['updateFilter']);
+import {createStore, StoreDefinition} from 'reflux';
 
 type State = {
   filter: string | null;
@@ -19,19 +15,11 @@ type Internals = {
   filter: string | null;
 };
 
-const storeConfig: StoreDefinition &
-  DebugMetaStoreInterface &
-  Internals &
-  SafeStoreDefinition = {
+const storeConfig: StoreDefinition & DebugMetaStoreInterface & Internals = {
   filter: null,
-  unsubscribeListeners: [],
 
   init() {
     this.reset();
-
-    this.unsubscribeListeners.push(
-      this.listenTo(DebugMetaActions.updateFilter, this.updateFilter)
-    );
   },
 
   reset() {
@@ -51,7 +39,7 @@ const storeConfig: StoreDefinition &
   },
 };
 
-const DebugMetaStore = createStore(makeSafeRefluxStore(storeConfig));
+const DebugMetaStore = createStore(storeConfig);
 
-export {DebugMetaActions, DebugMetaStore};
+export {DebugMetaStore};
 export default DebugMetaStore;