Browse Source

fix(integrations): Prevent warning for new integrations (#62649)

Only show elevating permission warning for existing integrations.
My FE knowledge is limited so please let me know if this is a good way
of doing this :|


https://github.com/getsentry/sentry/assets/67301797/e38405dd-ee4e-4694-ae5f-8479d79d8805

Fixes https://github.com/getsentry/sentry/issues/62619
Seiji Chew 1 year ago
parent
commit
7723aa758b

+ 1 - 0
static/app/views/settings/organizationDeveloperSettings/permissionsObserver.spec.tsx

@@ -15,6 +15,7 @@ describe('PermissionsObserver', () => {
         <PermissionsObserver
           scopes={['project:read', 'project:write', 'project:releases', 'org:admin']}
           events={['issue']}
+          newApp={false}
         />
       </Form>
     );

+ 2 - 1
static/app/views/settings/organizationDeveloperSettings/permissionsObserver.tsx

@@ -20,6 +20,7 @@ type DefaultProps = {
 
 type Props = DefaultProps & {
   events: WebhookEvent[];
+  newApp: boolean;
   scopes: Scope[];
 };
 
@@ -87,7 +88,7 @@ export default class PermissionsObserver extends Component<Props, State> {
   renderCallout() {
     const {elevating} = this.state;
 
-    if (elevating === true) {
+    if (!this.props.newApp && elevating === true) {
       return (
         <Alert type="warning" showIcon>
           {t(

+ 1 - 0
static/app/views/settings/organizationDeveloperSettings/sentryApplicationDetails.tsx

@@ -435,6 +435,7 @@ class SentryApplicationDetails extends DeprecatedAsyncView<Props, State> {
                     appPublished={app ? app.status === 'published' : false}
                     scopes={scopes}
                     events={events}
+                    newApp={!app}
                   />
                 </Fragment>
               );