ref(types): extend interface (#37517)

static/app/types/alerts.tsx

@@ -24,7 +24,7 @@ type IssueAlertRuleFormField =
  * These templates that tell the UI how to render the action or condition
  * and what fields it needs
  */
-export type IssueAlertRuleActionTemplate = {
+export interface IssueAlertRuleActionTemplate {
   enabled: boolean;
   id: string;
   label: string;
@@ -39,21 +39,18 @@ export type IssueAlertRuleActionTemplate = {
   link?: string;
   sentryAppInstallationUuid?: string;
   ticketType?: string;
-};
+}
 export type IssueAlertRuleConditionTemplate = IssueAlertRuleActionTemplate;
 
 /**
  * These are the action or condition data that the user is editing or has saved.
  */
-export type IssueAlertRuleAction = Omit<
-  IssueAlertRuleActionTemplate,
-  'formFields' | 'enabled'
-> & {
-  dynamic_form_fields?: IssueConfigField[];
-} & {
+export interface IssueAlertRuleAction
+  extends Omit<IssueAlertRuleActionTemplate, 'formFields' | 'enabled'> {
   // These are the same values as the keys in `formFields` for a template
   [key: string]: any;
-};
+  dynamic_form_fields?: IssueConfigField[];
+}
 
 export type IssueAlertRuleCondition = Omit<
   IssueAlertRuleConditionTemplate,
@@ -65,7 +62,7 @@ export type IssueAlertRuleCondition = Omit<
   [key: string]: number | string;
 };
 
-export type UnsavedIssueAlertRule = {
+export interface UnsavedIssueAlertRule {
   /** When an issue matches [actionMatch] of the following */
   actionMatch: 'all' | 'any' | 'none';
   actions: IssueAlertRuleAction[];
@@ -77,17 +74,17 @@ export type UnsavedIssueAlertRule = {
   name: string;
   environment?: null | string;
   owner?: string | null;
-};
+}
 
 // Issue-based alert rule
-export type IssueAlertRule = UnsavedIssueAlertRule & {
+export interface IssueAlertRule extends UnsavedIssueAlertRule {
   createdBy: {email: string; id: number; name: string} | null;
   dateCreated: string;
   id: string;
   projects: string[];
   errors?: {detail: string}[];
   lastTriggered?: string;
-};
+}
 
 // Project's alert rule stats
 export type ProjectAlertRuleStats = {

static/app/types/breadcrumbs.tsx

@@ -29,36 +29,36 @@ export enum BreadcrumbType {
   INIT = 'init',
 }
 
-type BreadcrumbTypeBase = {
+interface BreadcrumbTypeBase {
   level: BreadcrumbLevelType;
   // it's recommended
   category?: string | null;
   event_id?: string | null;
   message?: string;
   timestamp?: string;
-};
+}
 
-export type BreadcrumbTypeSystem = {
+export interface BreadcrumbTypeSystem extends BreadcrumbTypeBase {
   action: string;
   extras: Record<string, any>;
   type: BreadcrumbType.SYSTEM;
-} & BreadcrumbTypeBase;
+}
 
-export type BreadcrumbTypeSession = {
+export interface BreadcrumbTypeSession extends BreadcrumbTypeBase {
   action: string;
   extras: Record<string, any>;
   type: BreadcrumbType.SESSION;
-} & BreadcrumbTypeBase;
+}
 
-export type BreadcrumbTypeNavigation = {
+export interface BreadcrumbTypeNavigation extends BreadcrumbTypeBase {
   type: BreadcrumbType.NAVIGATION;
   data?: null | {
     from?: string;
     to?: string;
   };
-} & BreadcrumbTypeBase;
+}
 
-export type BreadcrumbTypeHTTP = {
+export interface BreadcrumbTypeHTTP extends BreadcrumbTypeBase {
   type: BreadcrumbType.HTTP;
   data?: null | {
     method?:
@@ -75,9 +75,9 @@ export type BreadcrumbTypeHTTP = {
     status_code?: number;
     url?: string;
   };
-} & BreadcrumbTypeBase;
+}
 
-export type BreadcrumbTypeDefault = {
+export interface BreadcrumbTypeDefault extends BreadcrumbTypeBase {
   type:
     | BreadcrumbType.INFO
     | BreadcrumbType.DEBUG
@@ -93,7 +93,7 @@ export type BreadcrumbTypeDefault = {
     | BreadcrumbType.SYSTEM
     | BreadcrumbType.TRANSACTION;
   data?: Record<string, any> | null;
-} & BreadcrumbTypeBase;
+}
 
 export type RawCrumb =
   | BreadcrumbTypeNavigation

static/app/types/debugFiles.tsx

@@ -50,9 +50,17 @@ export type AppStoreConnectValidationError = {
     | 'app-connect-multiple-sources-error';
 };
 
+interface ValidAppStoreConnectCredentialsStatus {
+  status: 'valid';
+}
+
+interface InvalidAppStoreConnectCredentialsStatus extends AppStoreConnectValidationError {
+  status: 'invalid';
+}
+
 export type AppStoreConnectCredentialsStatus =
-  | {status: 'valid'}
-  | ({status: 'invalid'} & AppStoreConnectValidationError);
+  | ValidAppStoreConnectCredentialsStatus
+  | InvalidAppStoreConnectCredentialsStatus;
 
 export type AppStoreConnectStatusData = {
   credentials: AppStoreConnectCredentialsStatus;

static/app/types/debugImage.tsx

@@ -94,11 +94,11 @@ export type CandidateDownload =
   | CandidateDownloadUnAppliedStatus
   | CandidateDownloadOtherStatus;
 
-type ImageCandidateBase = {
+interface ImageCandidateBase {
+  location: string;
   source: string;
-  location?: string;
   source_name?: string;
-};
+}
 
 type InternalSource = {
   cpuName: string;
@@ -110,35 +110,33 @@ type InternalSource = {
   symbolType: SymbolType;
 };
 
-export type ImageCandidateOk = ImageCandidateBase & {
+export interface ImageCandidateOk extends ImageCandidateBase {
   download: CandidateDownloadOkStatus;
   debug?: CandidateProcessingInfo;
   unwind?: CandidateProcessingInfo;
-};
+}
 
-export type ImageCandidateInternalOk = ImageCandidateBase &
-  InternalSource & {
-    download: CandidateDownloadOkStatus;
-    debug?: CandidateProcessingInfo;
-    unwind?: CandidateProcessingInfo;
-  };
-
-export type ImageCandidateUnApplied = ImageCandidateBase &
-  InternalSource & {
-    download: CandidateDownloadUnAppliedStatus;
-    source: string;
-    source_name?: string;
-  };
-
-type ImageCandidateOthers = ImageCandidateBase & {
+export interface ImageCandidateInternalOk extends ImageCandidateBase, InternalSource {
+  download: CandidateDownloadOkStatus;
+  debug?: CandidateProcessingInfo;
+  unwind?: CandidateProcessingInfo;
+}
+
+export interface ImageCandidateUnApplied extends ImageCandidateBase, InternalSource {
+  download: CandidateDownloadUnAppliedStatus;
+  source: string;
+  source_name?: string;
+}
+
+interface ImageCandidateOthers extends ImageCandidateBase {
   download:
     | CandidateDownloadNotFoundStatus
     | CandidateDownloadDeletedStatus
     | CandidateDownloadOtherStatus;
+  location: string;
   source: string;
-  location?: string;
   source_name?: string;
-};
+}
 
 export type ImageCandidate =
   | ImageCandidateOk