Browse Source

fix(replays): Guard against unknown span op (#49162)

Ryan Albrecht 1 year ago
parent
commit
725a27e0cb

+ 1 - 1
static/app/utils/replays/replayReader.tsx

@@ -188,5 +188,5 @@ const isMemorySpan = (span: ReplaySpan): span is MemorySpan => {
 };
 
 const isNetworkSpan = (span: ReplaySpan): span is NetworkSpan => {
-  return span.op.startsWith('navigation.') || span.op.startsWith('resource.');
+  return span.op?.startsWith('navigation.') || span.op?.startsWith('resource.');
 };

+ 1 - 1
static/app/utils/replays/splitAttachmentsByType.tsx

@@ -10,7 +10,7 @@ export default function splitAttachmentsByType(attachments: any[]) {
       if (span.op === 'memory') {
         rawMemorySpans.push(span);
       }
-      if (span.op.startsWith('navigation.') || span.op.startsWith('resource.')) {
+      if (span.op?.startsWith('navigation.') || span.op?.startsWith('resource.')) {
         rawNetworkSpans.push(span);
       }
     } else if (attachment.data?.tag === 'breadcrumb') {