Browse Source

fix(browser-starfish): domain-filter not working (#60398)

The query condition was incorrect here, we should definetely add some
tests here shortly after release!
Dominik Buszowiecki 1 year ago
parent
commit
714fef134d

+ 4 - 2
static/app/views/performance/browser/resources/utils/useResourcesQuery.ts

@@ -45,13 +45,15 @@ export const getResourcesEventViewQuery = (
     ...(resourceFilters.transaction
       ? [`transaction:"${resourceFilters.transaction}"`]
       : []),
-    ...getResourceTypeFilter(resourceFilters[SPAN_OP], defaultResourceTypes),
     ...getDomainFilter(resourceFilters[SPAN_DOMAIN]),
     ...(resourceFilters[RESOURCE_RENDER_BLOCKING_STATUS]
       ? [
           `${RESOURCE_RENDER_BLOCKING_STATUS}:${resourceFilters[RESOURCE_RENDER_BLOCKING_STATUS]}`,
         ]
       : [`!${RESOURCE_RENDER_BLOCKING_STATUS}:blocking`]),
+    'AND (',
+    ...getResourceTypeFilter(resourceFilters[SPAN_OP], defaultResourceTypes),
+    ')',
   ];
 };
 
@@ -145,7 +147,7 @@ export const getDomainFilter = (selectedDomain: string | undefined) => {
     return [`!has:${SPAN_DOMAIN}`];
   }
 
-  return [`${SPAN_DOMAIN}:${selectedDomain}`];
+  return [`${SPAN_DOMAIN}:"${selectedDomain}"`];
 };
 
 const SPAN_OP_FILTER = {

+ 1 - 1
static/app/views/performance/landing/widgets/components/widgetContainer.spec.tsx

@@ -925,7 +925,7 @@ describe('Performance > Widgets > WidgetContainer', function () {
           per_page: QUERY_LIMIT_PARAM,
           project: ['-42'],
           query:
-            '!span.description:browser-extension://* span.op:resource.script OR file_extension:css OR file_extension:[woff,woff2,ttf,otf,eot] !resource.render_blocking_status:blocking transaction.op:pageload',
+            '!span.description:browser-extension://* !resource.render_blocking_status:blocking AND ( span.op:resource.script OR file_extension:css OR file_extension:[woff,woff2,ttf,otf,eot] ) transaction.op:pageload',
           sort: '-time_spent_percentage()',
           statsPeriod: '7d',
         }),