Browse Source

ref(perf): Add VCD to discover homepage (#46956)

### Summary
This adds the **vcd** measurement to discover homepage, wrapping the
results table. It'll help us capture actual performance load times till
the table is visually complete.
Kev 1 year ago
parent
commit
7024673077
1 changed files with 17 additions and 11 deletions
  1. 17 11
      static/app/views/discover/table/index.tsx

+ 17 - 11
static/app/views/discover/table/index.tsx

@@ -17,6 +17,7 @@ import EventView, {
 import {SPAN_OP_BREAKDOWN_FIELDS} from 'sentry/utils/discover/fields';
 import Measurements from 'sentry/utils/measurements/measurements';
 import parseLinkHeader from 'sentry/utils/parseLinkHeader';
+import {VisuallyCompleteWithData} from 'sentry/utils/performanceForSentry';
 import withApi from 'sentry/utils/withApi';
 
 import TableView from './tableView';
@@ -216,17 +217,22 @@ class Table extends PureComponent<TableProps, TableState> {
             return (
               <CustomMeasurementsContext.Consumer>
                 {contextValue => (
-                  <TableView
-                    {...this.props}
-                    isLoading={isLoading}
-                    isFirstPage={isFirstPage}
-                    error={error}
-                    eventView={eventView}
-                    tableData={tableData}
-                    measurementKeys={measurementKeys}
-                    spanOperationBreakdownKeys={SPAN_OP_BREAKDOWN_FIELDS}
-                    customMeasurements={contextValue?.customMeasurements ?? undefined}
-                  />
+                  <VisuallyCompleteWithData
+                    id="Discover-Table"
+                    hasData={(tableData?.data?.length ?? 0) > 0}
+                  >
+                    <TableView
+                      {...this.props}
+                      isLoading={isLoading}
+                      isFirstPage={isFirstPage}
+                      error={error}
+                      eventView={eventView}
+                      tableData={tableData}
+                      measurementKeys={measurementKeys}
+                      spanOperationBreakdownKeys={SPAN_OP_BREAKDOWN_FIELDS}
+                      customMeasurements={contextValue?.customMeasurements ?? undefined}
+                    />
+                  </VisuallyCompleteWithData>
                 )}
               </CustomMeasurementsContext.Consumer>
             );