Home Explore Help
Sign In
SMusatov
/
sentry
mirror of https://github.com/getsentry/sentry
1
0
Fork 0
Files
Browse Source

chore(trace-view): remove keyboard icon and replace with shortcut words (#76270)

**Before:**
![Screenshot 2024-08-15 at 9 38
48 AM](https://github.com/user-attachments/assets/6adc0fda-a3d9-4d70-90a8-dca994ca3b0d)

**After:**
![Screenshot 2024-08-15 at 9 35
41 AM](https://github.com/user-attachments/assets/a76ee434-55ae-4f70-b8a3-2012d59bf731)
Dora 7 months ago
parent
223e325d68
commit
6f35b250b0
5 changed files with 3 additions and 32 deletions
Split View Show Diff Stats
  1. 0 21
      static/app/icons/iconKeyboard.tsx
  2. 0 6
      static/app/icons/icons.stories.tsx
  3. 0 1
      static/app/icons/index.tsx
  4. 1 1
      static/app/views/performance/newTraceDetails/index.tsx
  5. 2 3
      static/app/views/performance/newTraceDetails/traceShortcutsModal.tsx

+ 0 - 21
static/app/icons/iconKeyboard.tsx
View File 

@@ -1,21 +0,0 @@
 
-import {forwardRef} from 'react';
 
-
 
-import type {SVGIconProps} from './svgIcon';
 
-import {SvgIcon} from './svgIcon';
 
-
 
-const IconKeyboard = forwardRef<SVGSVGElement, SVGIconProps>((props, ref) => {
 
-  return (
 
-    <SvgIcon {...props} ref={ref}>
 
-      <path d="M15.28,13.49H.72c-.41,0-.75-.34-.75-.75V3.26c0-.41.34-.75.75-.75h14.56c.41,0,.75.34.75.75v9.49c0,.41-.34.75-.75.75ZM1.47,11.99h13.06v-7.99H1.47v7.99Z" />
 
-      <rect x="10.89" y="3.26" width="1.5" height="6.32" />
 
-      <rect x="3.61" y="3.26" width="1.5" height="6.32" />
 
-      <rect x="7.25" y="3.26" width="1.5" height="6.32" />
 
-      <rect x=".72" y="8.83" width="14.56" height="1.5" />
 
-      <rect x=".72" y="5.67" width="14.56" height="1.5" />
 
-    </SvgIcon>
 
-  );
 
-});
 
-
 
-IconKeyboard.displayName = 'IconKeyboard';
 
-
 
-export {IconKeyboard};

+ 0 - 6
static/app/icons/icons.stories.tsx
View File 

@@ -1029,12 +1029,6 @@ const SECTIONS: TSection[] = [
 
         name: 'Tap',
 
         defaultProps: {},
 
       },
 
-      {
 
-        id: 'keyboard',
 
-        keywords: ['keys', 'shortcut'],
 
-        name: 'Keyboard',
 
-        defaultProps: {},
 
-      },
 
       {
 
         id: 'thumb',
 
         keywords: ['feedback', 'good'],

+ 0 - 1
static/app/icons/index.tsx
View File 

@@ -52,7 +52,6 @@ export {IconInput} from './iconInput';
 
 export {IconIssues} from './iconIssues';
 
 export {IconJira} from './iconJira';
 
 export {IconJson} from './iconJson';
 
-export {IconKeyboard} from './iconKeyboard';
 
 export {IconKeyDown} from './iconKeyDown';
 
 export {IconLab} from './iconLab';
 
 export {IconLaptop} from './iconLaptop';

+ 1 - 1
static/app/views/performance/newTraceDetails/index.tsx
View File 

@@ -1033,7 +1033,7 @@ function TraceResetZoomButton(props: {
 
       onClick={onResetZoom}
 
       ref={props.viewManager.registerResetZoomRef}
 
     >
 
-      {t('Reset Zoom')}
 
+      {t('Reset')}
 
     </ResetZoomButton>
 
   );
 
 }

+ 2 - 3
static/app/views/performance/newTraceDetails/traceShortcutsModal.tsx
View File 

@@ -5,7 +5,6 @@ import tracingKeyboardShortcuts from 'sentry-images/spot/tracing-keyboard-shortc
 
 
 import {type ModalRenderProps, openModal} from 'sentry/actionCreators/modal';
 
 import {Button} from 'sentry/components/button';
 
-import {IconKeyDown} from 'sentry/icons';
 
 import {t} from 'sentry/locale';
 
 import {space} from 'sentry/styles/space';
 
 import useOrganization from 'sentry/utils/useOrganization';
 
@@ -20,7 +19,7 @@ export function TraceShortcuts() {
 
 
   return (
 
     <Button size="xs" onClick={onOpenShortcutsClick} aria-label={t('Trace Shortcuts')}>
 
-      <IconKeyDown />
 
+      Shortcuts
 
     </Button>
 
   );
 
 }
 
@@ -41,7 +40,7 @@ function TraceShortcutsModal({Header, Body}: ModalRenderProps) {
 
   return (
 
     <Fragment>
 
       <Header closeButton>
 
-        <h2>{t('Keyboard controls')}</h2>
 
+        <h2>{t('Shortcuts')}</h2>
 
       </Header>
 
       <Body>
 
         <ShortcutsLayout>