Browse Source

feat(metrics): Rename add query (#68961)

Rename to `Add metric`
Hide multi chart toggle when there is only one widget

- closes https://github.com/getsentry/sentry/issues/68878
- closes https://github.com/getsentry/sentry/issues/68879
ArthurKnaus 11 months ago
parent
commit
6ee0e1b0cc

+ 2 - 2
static/app/components/modals/metricWidgetViewerModal/queries.tsx

@@ -132,7 +132,7 @@ export function Queries({
       {displayType !== DisplayType.BIG_NUMBER && (
         <ButtonBar addQuerySymbolSpacing={showQuerySymbols}>
           <Button size="sm" icon={<IconAdd isCircled />} onClick={() => addQuery()}>
-            {t('Add query')}
+            {t('Add metric')}
           </Button>
           <Button size="sm" icon={<IconAdd isCircled />} onClick={addEquation}>
             {t('Add equation')}
@@ -189,7 +189,7 @@ function QueryContextMenu({
     const removeQueryItem = {
       leadingItems: [<IconClose key="icon" />],
       key: 'delete',
-      label: t('Remove Query'),
+      label: t('Remove Metric'),
       disabled: !canRemoveQuery,
       onAction: () => {
         removeQuery(queryIndex);

+ 1 - 1
static/app/views/metrics/metricFormulaContextMenu.tsx

@@ -82,7 +82,7 @@ export function MetricFormulaContextMenu({
       {
         leadingItems: [<IconClose key="icon" />],
         key: 'delete',
-        label: t('Remove Query'),
+        label: t('Remove Equation'),
         disabled: !canDelete,
         onAction: () => {
           Sentry.metrics.increment('ddm.widget.delete');

+ 1 - 1
static/app/views/metrics/metricQueryContextMenu.tsx

@@ -144,7 +144,7 @@ export function MetricQueryContextMenu({
       {
         leadingItems: [<IconClose key="icon" />],
         key: 'delete',
-        label: t('Remove Query'),
+        label: t('Remove Metric'),
         disabled: !canDelete,
         onAction: () => {
           Sentry.metrics.increment('ddm.widget.delete');

+ 10 - 8
static/app/views/metrics/queries.tsx

@@ -123,7 +123,7 @@ export function Queries() {
           icon={<IconAdd isCircled />}
           onClick={() => handleAddWidget(MetricExpressionType.QUERY)}
         >
-          {t('Add query')}
+          {t('Add metric')}
         </Button>
         <Button
           size="sm"
@@ -132,13 +132,15 @@ export function Queries() {
         >
           {t('Add equation')}
         </Button>
-        <SwitchWrapper>
-          {t('One chart per query')}
-          <SwitchButton
-            isActive={isMultiChartMode}
-            toggle={() => setIsMultiChartMode(!isMultiChartMode)}
-          />
-        </SwitchWrapper>
+        {widgets.length > 1 && (
+          <SwitchWrapper>
+            {t('One chart per metric')}
+            <SwitchButton
+              isActive={isMultiChartMode}
+              toggle={() => setIsMultiChartMode(!isMultiChartMode)}
+            />
+          </SwitchWrapper>
+        )}
       </ButtonBar>
     </Fragment>
   );