ref(ts): Fix lint issues that are being masked (#28454)

These are lint issues that will come up in a new version of `@typescript-eslint`. See https://github.com/getsentry/eslint-config-sentry/pull/105

.eslintignore

@@ -7,3 +7,4 @@
 !.github
 !.github/workflows/scripts/*
 !.storybook
+*.d.ts

static/app/components/commitLink.tsx

@@ -15,7 +15,7 @@ type CommitFormatterParameters = {
 type CommitProvider = {
   icon: React.ReactNode;
   providerIds: string[];
-  commitUrl: (CommitFormatterParameters) => string;
+  commitUrl: (opts: CommitFormatterParameters) => string;
 };
 
 // TODO(epurkhiser, jess): This should be moved into plugins.

static/app/components/contextData/index.tsx

@@ -29,6 +29,10 @@ type State = {
   withAnnotatedText: boolean;
 };
 
+function getValueWithAnnotatedText(v: Value, meta?: Meta) {
+  return <AnnotatedText value={v} meta={meta} />;
+}
+
 class ContextData extends React.Component<Props, State> {
   static defaultProps = {
     data: null,
@@ -40,11 +44,8 @@ class ContextData extends React.Component<Props, State> {
       this.props;
     const maxDepth = maxDefaultDepth ?? 2;
 
-    function getValueWithAnnotatedText(v: Value, meta?: Meta) {
-      return <AnnotatedText value={v} meta={meta} />;
-    }
-
-    /* eslint no-shadow:0 */
+    // TODO(eslint): Remove `no-shadow`
+    // eslint-disable-next-line no-shadow,@typescript-eslint/no-shadow
     function walk(value: Value, depth: number) {
       let i = 0;
       const children: React.ReactNode[] = [];

static/app/utils/theme.tsx

@@ -721,6 +721,7 @@ type MyTheme = Theme;
  * Configure Emotion to use our theme
  */
 declare module '@emotion/react' {
+  // eslint-disable-next-line @typescript-eslint/no-shadow
   export interface Theme extends MyTheme {}
 }
 

static/app/utils/withExperiment.tsx

@@ -100,8 +100,8 @@ function withExperiment<
       }
     }
 
-    getProps<P extends ExperimentType>() {
-      return this.props as unknown as ExpectedProps<P>;
+    getProps<Q extends ExperimentType>() {
+      return this.props as unknown as ExpectedProps<Q>;
     }
 
     get config() {

static/app/views/settings/project/navigationConfiguration.tsx

@@ -89,7 +89,8 @@ export default function getConfiguration({
         {
           path: `${pathPrefix}/processing-issues/`,
           title: t('Processing Issues'),
-          // eslint-disable-next-line no-shadow
+          // TODO(eslint): Remove `no-shadow`
+          // eslint-disable-next-line no-shadow,@typescript-eslint/no-shadow
           badge: ({project}) => {
             if (!project) {
               return null;

static/app/views/settings/project/projectOwnership/addCodeOwnerModal.tsx

@@ -132,7 +132,7 @@ class AddCodeOwnerModal extends Component<Props, State> {
     const {codeMappings} = this.props;
     const codeMapping = codeMappings.find(mapping => mapping.id === codeMappingId);
     const {integrationId, provider} = codeMapping as RepositoryProjectPathConfig;
-    const errActors = errorJSON?.raw?.[0].split('\n').map(el => <p>{el}</p>);
+    const errActors = errorJSON?.raw?.[0].split('\n').map((el, i) => <p key={i}>{el}</p>);
     return (
       <Alert type="error" icon={<IconNot size="md" />}>
         {errActors}

tests/js/setupFramework.ts

@@ -7,6 +7,8 @@ export {};
 
 declare global {
   namespace jest {
+    // eslint complains that R is unused, but we need to match interface,
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     interface Matchers<R> {
       toSnapshot(): CustomMatcherResult;
     }

tests/js/spec/views/organizationGroupDetails/groupEventDetails.spec.jsx

@@ -421,7 +421,7 @@ describe('groupEventDetails', () => {
         body: [unpublishedInstall, internalInstall],
       });
 
-      wrapper = mountWithThemeWrapper();
+      mountWithThemeWrapper();
     });
 
     it('loads Integration UI components', () => {